534313 - nanojit: split isQuad() into isI64() + isF64() + is64()

Status: RESOLVED FIXED

(Core Graveyard :: Nanojit, defect)

Description

[Nicholas Nethercote [inactive]]

Or names something like that.

Comment 1

[Andreas Gal :gal]

If we are copying a quad, we should not inhibit register trading (gprs are usually all full, xmms mostly empty).

Comment 2

[Nicholas Nethercote [inactive]]

Sure.  But there may be cases where we put a constant in GpRegs when it's really a float, or in XmmRegs when it's really an int, and then subsequently do arithmetic on it.  These ones will be improved.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: NJ patch

This patch removes isQuad().  Some details:

- I removed fpn(), because it's identical to gpn() and was only used in a
  couple of places.

- You could argue that I should have kept isQuad() around to use in places
  where we now have 'isI64() || isF64()'.  I deliberately didn't do this
  because I'm trying to remove all traces of the "quad" terminology and the
  type-unsafe thinking behind it.  (If people really want something like
  this, I could add 'isN64()'.)

- I updated SanityFilter to allow testing, but it will be replaced wholesale
  when the LIR type-checker (bug 463137) is committed.

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: TM patch

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: TR patch

There are a couple of places in this patch where we now have 'ins->isI64()
|| ins->isF64()', but a stronger test of just 'ins->isI64()' or
'ins->isF64()' might be possible, I couldn't tell.  Whoever commits the TR
patch might like to consider this.

Nb: I updated ValidateWriter but the LIR type-checker (bug 463137) should be
committed first, whereupon those changes should be discarded because
ValidateWriter has been moved into nanojit/LIR.cpp.

Passes TR acceptance tests on my local machine, and passes the TR try server.

Comment 6

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/projects/nanojit-central/rev/f24a70adec4c

Comment 7

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/tracemonkey/rev/9577be7c0add
http://hg.mozilla.org/tracemonkey/rev/a2e95fbd7178

Comment 8

[Steven Johnson]

http://hg.mozilla.org/tamarin-redux/rev/9e55dfb8323c
http://hg.mozilla.org/tamarin-redux/rev/b90fb31b12cc

Comment 9

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/9577be7c0add