Closed
Bug 534452
Opened 15 years ago
Closed 14 years ago
add-on menu Most popular/more... displays All instead of All/Popular
Categories
(Mozilla Labs Graveyard :: Personas Plus, defect, P1)
Mozilla Labs Graveyard
Personas Plus
Tracking
(Not tracked)
VERIFIED
FIXED
1.5
People
(Reporter: gekacheka, Assigned: jose)
References
()
Details
Personas client 1.5rc2 Steps to reproduce: 1. Personas Menu > Most Popular > More from Most Popular... Actual: http://www.getpersonas.com/en-US/gallery/Most%20Popular/All which appears to be unrecongized and displays "Personas Home : Gallery : All" Expected: http://www.getpersonas.com/en-US/gallery/All/Popular which displays "Personas Home : Gallery : All : Popular" ("More from New and Featured" does the same thing [displays All], but there is no "new and featured" category in the getpersonas.com gallery so I don't know what to expect. Maybe separate "more new" from "more featured" menu items, then "more new" can go to All/Recent instead of All.) These menu items may be important access to the gallery for non-english reading users, so they should go to the correct page. (Assuming the menu items are localized and getpersonas.com is not, or not in as many locales.)
Comment 1•15 years ago
|
||
I see this too. Ironically, it appears to be intentional, per this code: if (category == "popular" || category == "recent") { item.setAttribute("oncommand", "PersonaController.openURLInTab(this._siteURL + 'gallery/All/All')"); However, I agree with the reporter that the behavior is suboptimal, and we should load /gallery/All/Popular when that menu item is selected. The New & Featured link has the same problem (along with the additional problem that its label contains the total number of personas rather than just the number that are actually New & Featured), although it's not clear where it's supposed to go (/gallery/All/Recent?).
OS: Windows 2000 → All
Hardware: x86 → All
Updated•14 years ago
|
Target Milestone: -- → Future
Comment 2•14 years ago
|
||
moving to 1.5 for 1.5.2 release.
Priority: -- → P1
Target Milestone: Future → 1.5
Assignee | ||
Comment 3•14 years ago
|
||
Which are the correct URLs for these two menu items then? ("More from Popular" and "More from New & Features")
Assignee: cbeard → jose
Status: NEW → ASSIGNED
Comment 4•14 years ago
|
||
Popular: http://www.getpersonas.com/gallery/All/Popular New & Featured: http://www.getpersonas.com/gallery/All/Recent We don't have a full Featured category, so New & Featured will just link to recent submissions.
Assignee | ||
Comment 5•14 years ago
|
||
Fixed in rev: http://hg.mozilla.org/labs/personas/rev/78f97eadc174 Although the issue about the "New & Featured" label containing the total number of personas rather than just the number that are new & features remains.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 6•14 years ago
|
||
verified on 3.6 and 1.5.2rc2 Persona Plus Extension !
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Product: Mozilla Labs → Mozilla Labs Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•