534561 - parts of windowed plugins not updated after scrolling

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Karl Tomlinson (:karlt)]

Attachment: testcase

1) Load testcase.
2) Scroll up and down.

Actual results:
   Sometimes some of the plugin contains the screen's previous content.
   The effect is most obvious when scrolling with the mouse wheel and when
   smooth scrolling is off.  The effect can also be reproduced with other
   scrolling methods (arrow keys, scroll bar arrows).

Reload to see expected results.

Comment 1

[Karl Tomlinson (:karlt)]

This was with m-c 3ff17b03644e, which has the fix for bug 532404.

I still have suspicions about the "+ aDelta" here:
http://hg.mozilla.org/mozilla-central/annotate/3ff17b03644e/widget/src/windows/nsWindow.cpp#l2349

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Perhaps we should check both the before and after rects? If you have a Windows build, can you test that?

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

roc: thoughts on blocking?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think it should.

Comment 5

[Joe Drew (not getting mail)]

Is this a regression from bug 518506?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

No.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The patch makes a few important changes:
-- invalidate the widgets that extend outside the blit area *before* we scroll,
as well as the ones that extend outside the blit area *after* we scroll
-- invalidate all affected widgets, not just the ones for which we were passed
in a Configuration change, by looping over our children
-- invalidate the widgets *after* we've done the blit and moved the widget, to
ensure that everything we want to repaint is visible
-- invalidate the widgets by adding their area to InvalidateRgnInWindowSubtree,
to ensure that not just the widget itself but also all descendant widgets are
invalidated as necessary

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 417779 [details] [diff] [review]
fix

Needs 1.9.2 approval. I think this should block anyway

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Blocking, then, no approval needed!

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/673dc988cfbd
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/dd754f317ba3