534579 - Tab thumbnail takes 1/2 a second longer to disappear after tab close

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b5pre)
Gecko/20091213 Firefox/3.6b5pre Fennec/1.0b6pre

Steps to Reproduce:
1. Open two tabs
2. Open the tab sidebar
3. Close the most recently opened tab

Actual Results:
The border highlight will move to the active tab immediately, but closing the tab and its thumbnail takes 1/2 - 1 second longer.

Expected Results:
The border highlight, tab thumbnail and tab should close much quicker.

Comment 2

[Aakash Desai [:aakashd]]

From bug 534815...

Maybe we should clear the browser and hide the tab. That way we can reuse it
for the next tabopen.

JS profiling shows it can take 500ms to removeChild the browser, while it only
takes 3ms to removeChild the tab.

Likewise, it can take 120ms to create a browser. If we just shutdown the
browser when closing and then reuse it when opening a new tab, we can save some
significant time overall.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Instead of reusing the tab, this patch reorders the destruction order and delays the removeChild(browser) so the UI can show the tab removal quickly.

The patch also adds some function names to aid in profiling

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

missed the removeProgresslistener

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/baaa5720f04f

Comment 6

[Aakash Desai [:aakashd]]

The latest patch closes tabs super fast on the n810 and only when I close a non-active tab on the n900. When I close the active tab on the n900, it results in the same reported issue. Does anyone else see this? I'm going to have to re-open if its confirmed.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Please re-file rather than reopening - one patch per bug!

Comment 8

[Aakash Desai [:aakashd]]

Actually, I restarted Fennec and this didn't happen again. I tried laoding
heavy content sites on multiple tabs and closing them, but the poor tab close
performance hasn't returned. I'd like to get a confirmation from someone else
that this is working for them before verifying this.