Closed
Bug 534587
Opened 15 years ago
Closed 14 years ago
Bugmail uses the timezone of the changee instead of the user receiving the mail
Categories
(Bugzilla :: Email Notifications, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.4
People
(Reporter: reed, Assigned: reed)
Details
Attachments
(2 files, 1 obsolete file)
3.88 KB,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
3.24 KB,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
Instead of using the user's chosen timezone for displaying the comment header in bugmail, it seems the changee's timezone is used. Untested patch attached.
Attachment #417436 -
Flags: review?(mkanat)
Comment 1•15 years ago
|
||
Comment on attachment 417436 [details] [diff] [review] patch - v1 This looks basically right. However: * "undef" doesn't exist in TT, that's just another variable name. It will just pass an empty string, so the thing that needs to be done there is just to pass an empty string and then modify format_time to check $format instead of just "defined $format". * I think we should just pass the whole $user object as to_user, to the template. I've wanted that many times anyhow.
Attachment #417436 -
Flags: review?(mkanat) → review-
Assignee | ||
Comment 2•15 years ago
|
||
(In reply to comment #1) > * "undef" doesn't exist in TT, that's just another variable name. It will just > pass an empty string I wondered about that, but a mxr search for "undef" under template/ returned a few things, so I thought it might work. http://mxr.mozilla.org/bugzilla/search?string=undef&find=%2Ftemplate&findi=&filter=^[^\0]*%24&hitlimit=&tree=bugzilla > * I think we should just pass the whole $user object as to_user, to the > template. I've wanted that many times anyhow. Ok, can do. New patch coming up in a bit.
Assignee | ||
Comment 3•15 years ago
|
||
How about this?
Attachment #417436 -
Attachment is obsolete: true
Attachment #417607 -
Flags: review?(mkanat)
Comment 4•15 years ago
|
||
Comment on attachment 417607 [details] [diff] [review] patch - v2 (tip) That looks pretty reasonable. I'll test it before checkin. For the 3.4 branch, we shouldn't take away "to", because that could break somebody's custom email template.
Attachment #417607 -
Flags: review?(mkanat) → review+
Comment 5•15 years ago
|
||
(Another patch for 3.4 that doesn't remove "to" would help out with the checkin process.)
Flags: approval3.4?
Flags: approval+
Assignee | ||
Comment 6•15 years ago
|
||
Attachment #417608 -
Flags: review?(mkanat)
Updated•15 years ago
|
Attachment #417608 -
Flags: review?(mkanat) → review+
Updated•15 years ago
|
Flags: approval3.4? → approval3.4+
Assignee | ||
Updated•15 years ago
|
Attachment #417607 -
Attachment description: patch - v2 → patch - v2 (tip)
Assignee | ||
Comment 7•14 years ago
|
||
tip: Checking in Bugzilla/BugMail.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v <-- BugMail.pm new revision: 1.132; previous revision: 1.131 done Checking in Bugzilla/Util.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v <-- Util.pm new revision: 1.100; previous revision: 1.99 done Checking in template/en/default/email/newchangedmail.txt.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/email/newchangedmail.txt.tmpl,v <-- newchangedmail.txt.tmpl new revision: 1.18; previous revision: 1.17 done BUGZILLA-3_4-BRANCH: Checking in Bugzilla/BugMail.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v <-- BugMail.pm new revision: 1.124.2.6; previous revision: 1.124.2.5 done Checking in Bugzilla/Util.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v <-- Util.pm new revision: 1.86.2.5; previous revision: 1.86.2.4 done Checking in template/en/default/email/newchangedmail.txt.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/email/newchangedmail.txt.tmpl,v <-- newchangedmail.txt.tmpl new revision: 1.12.2.5; previous revision: 1.12.2.4 done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•