Closed Bug 534613 Opened 15 years ago Closed 15 years ago

nanojit change for MOPS opcodes causes some failures without SSE supprot

Categories

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)

Product:
Tamarin Graveyard
Component:
Baseline JIT (CodegenLIR)
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: brbaker, Assigned: stejohns)

References

Details

(Whiteboard: INJECTION, fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey)

Attachments

(1 file)

Patch
1.01 KB, patch
edwsmith
: review+
n.nethercote
: review+
Details | Diff | Splinter Review 
Recent change to nanojit for MOPS support (bug #458279, rev 3295:b1842cff6d9f) is causing an acceptance failure when running the debugger builds with -Dnosse in the mops testcase and a couple of the abcasm tests:


abcasm/mops.abc : Load uint as single-precision number FAILED! expected: 4.436589549552232e-272, actual: 3.1415698528289795

abcasm/nullCheck/L.abc : null lf32 FAILED! expected: 0, actual: 5.8841405527512986e-300

mops/mops.abcmops/mops.abc_ : Read/write float min = false FAILED! expected: true

mops/mops.abcmops/mops.abc_ : Read/write float scratch = false FAILED! expected: true
Flags: in-testsuite+
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
Attached patch Patch — — Splinter Review 
asm_load64 for i386 wasn't properly copying the loaded value into the stack frames in all cases (for non-sse2 path).
Assignee: nobody → stejohns
Attachment #417508 - Flags: review?(edwsmith)
Attachment #417508 - Flags: review?(nnethercote)
Attachment #417508 - Flags: review?(edwsmith) → review+
pushed to nj-c (in advance of nick's review) in changeset:   1108:107017b4c232 to fix injection

pushed to TR in changeset:   3325:e70606abf7c9
Attachment #417508 - Flags: review?(nnethercote) → review+
http://hg.mozilla.org/tracemonkey/rev/212a5664fd79
Whiteboard: INJECTION → INJECTION, fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey
Pretty sure that this has been pushed to all relevant repos, shall we close it?
Flags: flashplayer-qrb? → flashplayer-qrb+
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: