Closed Bug 534796 Opened 12 years ago Closed 11 years ago

IPC should use common setup for third_party files

Categories

(Core :: IPC, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 560615

People

(Reporter: t.matsuu, Unassigned)

References

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; ja; rv:1.9.3a1pre) Gecko/20091214 Fedora/3.7a1pre-0.a1pre.2009121410.fc12 Minefield/3.7a1pre
Build Identifier: 

Generally, mozilla use nspr and nss which is included in source tarball or system ones (--with-system-nss/nspr with top configure script).

But ipc/chromium/src/base/basictypes.h which is included by xpcom/build/nsXPComInit.cpp tries to include "nspr/prtypes.h".  When I use "--with-system-nspr" with top configure script, the compilation of nsXPComInit.cpp is failed.

I think IPC should use nspr and nss not in ipc/chromium/src/base/third_party but selected by top configure script.

I suppose IPC suould use purify sources not in ipc/chromium/src/base/third_party but in xpcom/base.

Reproducible: Always
Blocks: OOPP
Attached patch NSPR part of fixSplinter Review
Same manner of fix as bug560615.

Chris, can you review this?
Attachment #443864 - Flags: review?(jones.chris.g)
Comment on attachment 443864 [details] [diff] [review]
NSPR part of fix

bent is a better reviewer of this patch, he's dug around in this code.  I think chromium modified its NSPR, and I'm not sure it's compatible with our version/the system version.
Attachment #443864 - Flags: review?(jones.chris.g) → review?(bent.mozilla)
Comment on attachment 443864 [details] [diff] [review]
NSPR part of fix

Chromium has a modified version in there, yeah. I'm not sure it's worth trying to fix either. I'd recommend WONTFIX until we remove the chromium stuff entirely rather than hacking it more, but I'll let bsmedberg decide.
Attachment #443864 - Flags: review?(bent.mozilla) → review?(benjamin)
Isn't this a dup of bug 560615?
No, this is about using --with-system-nspr and excluding chromium's modified version.
But... it so much looks like that bug is about the same thing.
Attachment #443864 - Flags: review?(benjamin) → review?(bent.mozilla)
Actually, I think I'm crazy. Takanori, do you still have this problem now that the fix for bug 560615 has landed?
No problem now.
Thanks!
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 560615
You need to log in before you can comment on or make changes to this bug.