Closed Bug 534922 Opened 12 years ago Closed 12 years ago

NS_DebugBreak(NS_DEBUG_ABORT) must trigger breakpad

Categories

(Core :: XPCOM, defect)

Other Branch
x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: benjamin, Assigned: cjones)

References

Details

Attachments

(1 file)

NS_RUNTIMEABORT should trigger breakpad instead of silently aborting. I think we have the ability to test this with the crasher-component now, even.
Flags: in-testsuite?
NS_RUNTIMEABORT isn't doing anything special.
Summary: NS_RUNTIMEABORT must trigger breakpad → NS_DebugBreak(NS_DEBUG_ABORT) must trigger breakpad
Should probably use bug 532490 here.
Testing on windows right now, but it will take a while for me to rebuild.
Attachment #417740 - Flags: review?(benjamin)
Just confirmed that this hack triggers breakpad.
Attachment #417740 - Flags: review?(benjamin) → review+
Pushed http://hg.mozilla.org/projects/electrolysis/rev/e897841b4db6.  I'll go ahead and close this bug; if we want a less hacky solution, it can be implemented under the aegis of another bug.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Merged to mozilla-central at http://hg.mozilla.org/mozilla-central/rev/4eef63c0c6c9
You need to log in before you can comment on or make changes to this bug.