534934 - mochitest-ipcplugins: OSError: [Errno 10] No child processes

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

[PluginModuleChild] AnswerPPluginInstanceConstructor: returning 0
[PluginInstanceChild] NPP_SetWindow(0x0, 21, 389, 400 x 100)
TEST-UNEXPECTED-FAIL | automation.py | Exited with code 11 during test run
INFO | automation.py | Application ran for: 0:00:07.338616
INFO | automation.py | Reading PID log: /tmp/tmptz3J7gpidlog
==> process 2439 launched child process 2475
INFO | automation.py | Checking for orphan process with PID: 2475
Traceback (most recent call last):
  File "/builds/moz2_slave/mozilla-central-linux-opt-unittest-everythingelse/build/mochitest/runtests.py", line 514, in <module>
    main()
  File "/builds/moz2_slave/mozilla-central-linux-opt-unittest-everythingelse/build/mochitest/runtests.py", line 412, in main
    timeout = timeout)
  File "/builds/moz2_slave/mozilla-central-linux-opt-unittest-everythingelse/build/mochitest/automation.py", line 627, in runApp
    if isPidAlive(processPID):
  File "/builds/moz2_slave/mozilla-central-linux-opt-unittest-everythingelse/build/mochitest/automation.py", line 474, in isPidAlive
    wpid, wstatus = os.waitpid(pid, os.WNOHANG)
OSError: [Errno 10] No child processes
program finished with exit code 1
elapsedTime=9.708806
TinderboxPrint: mochitest-ipcplugins<br/><em class="testfail">T-FAIL</em>
Unknown Error: command finished with exit code: 1

The os.kill call above is *supposed* to check for this case, but I'm guessing that the process is exiting inbetween the os.kill and os.waitpid, and we should just add an except block for this case.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: patch

I did as you suggested.  Do you want this pushed to m-c, e10s, or both?

Comment 2

[Benjamin Smedberg]

Comment on attachment 417799 [details] [diff] [review]
patch

I'll land this on e10s and merge to m-c.

Comment 3

[Benjamin Smedberg]

http://hg.mozilla.org/projects/electrolysis/rev/2012cd379192

Comment 4

[Benjamin Smedberg]

Merged to mozilla-central at http://hg.mozilla.org/mozilla-central/rev/4eef63c0c6c9