535079 - Optimize _XPCNativeWrapperCtor to lessen / remove impact on startup

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Robert Strong (they/them - no direct email)]

Talked with mrbkap about this and he asked me to file.

Using the patch from bug 507012 I see the following calls after the command-line-startup notification and before the final-ui-startup notification.
function: 003B96C8 na -1 XPCNativeWrapper 0 1 1260830326920876
function: 003B96C8 na -1 XPCNativeWrapper 0 0 1260830326921015
function: 003B9F18 na -1 XPCNativeWrapper 0 1 1260830326988695
function: 003B9F18 na -1 XPCNativeWrapper 0 0 1260830326988838
function: 003B9818 javascript:return_new_XPCNativeWrapper(arg); 1 _XPCNativeWrapperCtor 1 1 1260830327038569
function: 003B9F18 na -1 XPCNativeWrapper 0 1 1260830327038766
function: 003B9F18 na -1 XPCNativeWrapper 0 0 1260830327038967

The above numbers are pretty consistent on WinCE Firefox using a Tegra. The totals are:
  startup|0|_XPCNativeWrapperCtor (118.2ms) - represents the time taken from the first call (1260830326920876) to the last call (1260830327038967)
    na|-1|XPCNativeWrapper (0.139ms)
    na|-1|XPCNativeWrapper (0.143ms)
    javascript:return_new_XPCNativeWrapper(arg);|1|_XPCNativeWrapperCtor (0.507ms)
      na|-1|XPCNativeWrapper (0.201ms)

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/cfcbfa2d384b

Comment 3

[Robert Strong (they/them - no direct email)]

Regretfully this didn't affect startup but it appears to have moved the time to the extension manager which is being called by nsAppRunner during startup and I know of a fairly trivial way to improve this.