Failed to build Thunderbird trunk in Solaris

RESOLVED FIXED in Thunderbird 3.1a1

Status

Thunderbird
Build Config
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Boying Lu, Assigned: Boying Lu)

Tracking

Trunk
Thunderbird 3.1a1
x86
Solaris
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
When tried to build latest TB trunk code, I got following error:
comm-central/configure: test: unknown operator ==

The root cause is that /bin/sh is not bash on Solaris
(Assignee)

Comment 1

9 years ago
Created attachment 417880 [details] [diff] [review]
Use "=" instead of "=="
Assignee: nobody → brian.lu
Attachment #417880 - Flags: review?(wtc)
Comment on attachment 417880 [details] [diff] [review]
Use "=" instead of "=="

Stealing review - sorry it was my fault when I checked in a quick bustage fix yesterday.

r=Standard8
Attachment #417880 - Flags: review?(wtc) → review+

Comment 3

9 years ago
Comment on attachment 417880 [details] [diff] [review]
Use "=" instead of "=="

r=wtc.
Attachment #417880 - Flags: review+

Comment 4

9 years ago
Removing the bashism fixes also linking failure of thunderbird-bin on Ubuntu (/usr/bin/ld: cannot find -lmozsqlite3).
(Assignee)

Comment 5

9 years ago
(In reply to comment #4)
> Removing the bashism fixes also linking failure of thunderbird-bin on Ubuntu
> (/usr/bin/ld: cannot find -lmozsqlite3).

I tried the latest trunk code + my patch on ubuntu 9.10. It works well.
Can you tell me how to re-produce the error?

Comment 6

9 years ago
(In reply to comment #5)

> I tried the latest trunk code + my patch on ubuntu 9.10. It works well.
> Can you tell me how to re-produce the error?

Sorry if my wording was unclear: your patch removes the bashism, fixing the build on Ubuntu. Different from Solaris, there is no error on configure, the check just fails silently, the build fails first when trying to link thunderbird-bin about an hour later.

To reproduce the error: don't apply the patch ;-)

Can anything be done to expedite the checkin?
(In reply to comment #6)
> Can anything be done to expedite the checkin?

Normally I'd expect checkin-needed to be added to the keywords if Boying can't do it himself.

Anyway, checked this in:

http://hg.mozilla.org/comm-central/rev/2785b74de5c0
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
You need to log in before you can comment on or make changes to this bug.