535316 - tiki-login.php does not pass locale to tiki-login_scr.php

Status: VERIFIED FIXED

(support.mozilla.org :: Localization, task)

Description

[Paul Craciunoiu [:paulc]]

STR:
1. Logged out, visit http://support.mozilla.com/vi/kb/Deleting+cookies
2. Click on the sidebar "Log in" link ("Đăng Nhập") -- note the link: http://support.mozilla.com/tiki-login.php?locale=vi

AR:
Redirection to https://support.mozilla.com/tiki-login_scr.php

ER:
Redirection to https://support.mozilla.com/tiki-login_scr.php?locale=vi

Comment 1

[James Socol [:jsocol, :james]]

Unassigning a few [good first bug]s.

Comment 2

[Tobias (:Tobbi) Markus]

Attachment: Adding locale parameter to the URL opened

This should fix it. I added the locale param to the URL.

Comment 3

[Paul Craciunoiu [:paulc]]

Comment on attachment 419955 [details] [diff] [review]
Adding locale parameter to the URL opened

Works, but for English en-US turns into en, which I forgot to mention when you asked. Can you use $_GET instead of $_REQUEST?

Comment 4

[Tobias (:Tobbi) Markus]

Attachment: v2

Replaced REQUEST with GET

Comment 5

[Paul Craciunoiu [:paulc]]

Comment on attachment 419968 [details] [diff] [review]
v2

WFM. Committed as r58923.
Thanks Tobbi!

Comment 6

[Paul Craciunoiu [:paulc]]

LPH: you may upstream if this is not in tiki. Otherwise just mark it as sumo_only.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; clicking on that link took me to https://support-stage.mozilla.org/tiki-login_scr.php?locale=vi

Comment 8

[Louis-Philippe Huberdeau]

Just adding that parameter everywhere is not really a solution for tiki. Perhaps a more centralized handling would be good.

Comment 9

[James Socol [:jsocol, :james]]

Reopening to commit to branches/1.5.1_temp. Will re-resolve after patches are committed.

Comment 10

[James Socol [:jsocol, :james]]

On branch, r62436

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://support-stage.mozilla.org/tiki-login.php?locale=vi; I was taken to https://support-stage.mozilla.com/tiki-login_scr.php?locale=vi.