535670 - Poor UX on password change while connected

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Zandr Milewski [:zandr]]

Weave 1.0b3

STR:

Connect to Weave.

Got to http://auth.services.mozilla.com/weave-password-reset and go through the motions to reset your password.

Sync Now

You'll get an unknown error instead of a password error. (Problem 1)

Open Prefs and click Change Password.

You'll get the three line (Old/New/New) change password sheet. (Problem 2)

Disconnect, then Connect

You'll get a password error, and the change password sheet will have two rows as it should.

Enter your new password.

You'll get an error sheet 

[Javascript Application]
Your current password is incorrect!
     ( OK )


But... it isn't. You're set, you can sync and connect/disconnect.

Comment 1

[Mike Connor [:mconnor]]

Okay, so:

a) we should catch whatever that error is, and if we can make a meaningful decision there, we should attempt to re-login.
b) Disconnect/Connect really shouldn't hit that error... like, the condition we test for when hiding the field should also be hit before we get to that code block... did you do something funky in between?

Comment 2

[Ed Lee :Mardak]

I haven't looked at the code, but it seems like because we reuse the change password dialog instead of just asking for the (correct) password, the change dialog prompt tries to use the current (incorrect) password and triggers the prompt and then sets it to the changed password somehow.

Also, any reason you need to enter the password twice when changing it from an incorrect one?

Comment 3

[Zandr Milewski [:zandr]]

(In reply to comment #1)

> b) Disconnect/Connect really shouldn't hit that error... like, the condition we
> test for when hiding the field should also be hit before we get to that code
> block... did you do something funky in between?

The [Javascript Application] error? We hit that *after* you enter your *correct* password.

Nothing done (funky or otherwise) in between the steps described in comment 0.

Comment 4

[Zandr Milewski [:zandr]]

Possibly related. If you 'start over' and create a new account, when you're done, you're left Not Signed In, with a bad password error triangle.

Connect works normally at this point and signs you in with your new account

Comment 5

[Zandr Milewski [:zandr]]

Hrrm, unable to reproduce comment #4.

Comment 6

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/64208ed7f321
Detect if there was a login failure when opening the prefs and re-use the first-sign-in flow and feedback instead of using the change pwd/pph dialog.