Closed
Bug 535685
Opened 16 years ago
Closed 16 years ago
xpcwrappedjs doesn't deal with dipper parameters properly
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
Attachments
(1 file)
913 bytes,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
In particular, it doesn't create an out object for JavaScript to stick stuff in.
Assignee | ||
Comment 1•16 years ago
|
||
Comment 2•16 years ago
|
||
Yay, this fixes the problem for me.
In particular (to jog my memory in the future lest I forget):
IDL:
void generateKeypair(in ACString aPassphrase, in ACString aSalt,
in ACString aIV, out ACString aEncodedPublicKey,
out ACString aWrappedPrivateKey);
JS impl being called from JS was failing in the return. bkap's workaround in the impl was:
if (typeof outparam != "object");
outparam = {};
Woo!
Comment 3•16 years ago
|
||
Comment on attachment 418298 [details] [diff] [review]
Proposed fix
Needs test.
Attachment #418298 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 4•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/420131e7219d
I don't have time to write the test for this.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Assignee | ||
Updated•7 years ago
|
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•