535685 - xpcwrappedjs doesn't deal with dipper parameters properly

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

In particular, it doesn't create an out object for JavaScript to stick stuff in.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

Comment 2

[Justin Dolske [:Dolske]]

Yay, this fixes the problem for me.

In particular (to jog my memory in the future lest I forget):

IDL:

  void generateKeypair(in ACString aPassphrase, in ACString aSalt,
                       in ACString aIV, out ACString aEncodedPublicKey,
                       out ACString aWrappedPrivateKey);

JS impl being called from JS was failing in the return. bkap's workaround in the impl was:
        if (typeof outparam != "object");
            outparam = {};

Woo!

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 418298 [details] [diff] [review]
Proposed fix

Needs test.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/420131e7219d

I don't have time to write the test for this.