Closed
Bug 53569
Opened 24 years ago
Closed 24 years ago
leaks up from 1k to 808k
Categories
(SeaMonkey :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
M18
People
(Reporter: jud, Assigned: eric)
References
Details
(Keywords: memory-leak)
Attachments
(1 file)
639 bytes,
patch
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•24 years ago
|
Comment 1•24 years ago
|
||
new memory leaks are considered tree blockers. adding smoketest keyword until
someone claims this bustage.
Comment 2•24 years ago
|
||
mstoltz checkin to nsXMLDocument.cpp is one leak: unneeded addref at line 276.
erik checkin to nsFontMetricsGTK.cpp is another: missing release for "converter"
in routine "CheckMap()". Also an old leak like that one a few lines down.
Reporter | ||
Updated•24 years ago
|
Is it known whether either of these is the problem on tinderbox? Has anyone run
the refcount balancer on the leaked nsXULDocument?
Comment 4•24 years ago
|
||
Comment 5•24 years ago
|
||
r=brendan@mozilla.org on that leak fix
One question, not priority because it has nothing to do with the leak: can
GetCodebasePrincipal return a null principal pointer through the out parameter,
but return NS_OK to rv? If so, is that the right return code to propagate in
the case where there is no principal?
/be
A tinderbox build that *did* have the nsXULDocument fix didn't show any
improvement in leak stats. Has someone run the refcount balancer on the leaked
nsXULDocument? I don't have a current tree, or a machine on which I can build
and display locally.
Comment 8•24 years ago
|
||
It was nsXMLDocument::Load, not nsXULDocument, and I don't think that's code that
gets run during the normal course of things, so it probably wasn't affecting the
leak stats at all. Nonetheless, it's fixed.
Comment 9•24 years ago
|
||
I checked in a fix for the new leak, and there is a bug for the old leak
(bug 53585).
Looks like evaughan's changes fixed this...
Comment 11•24 years ago
|
||
this was evaughan, and is now fixed. is this still valid? removing from
smoketest list.
Keywords: smoketest
Comment 13•24 years ago
|
||
resolving as fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 14•24 years ago
|
||
anyone on linux who can verify this?
Comment 15•24 years ago
|
||
There is still 7 KB left of the leak. (It was 1 KB before the trouble and
Tinderbox shows 8 KB now). Before verifieing this bug, please check that those
are covered by some other bug so that they are not lost.
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•