535815 - Personas reset event not captured on page unload

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Personas Plus, defect, P2)

Description

[Ryan Doherty (:rdoherty)]

Firefox 3.5.6 & Personas 1.5

STR:

1) Go to http://www.getpersonas.com/en-US/gallery/
2) Mouseover a thumbnail, view preview in browser
3) Click on thumbnail (not either of the buttons 'wear this' or 'details'
4) Observe preview is not reverted when the page changes

Expected behavior:

Persona is reset.

I've checked my code and I'm firing the reset persona event onclick, but it doesn't seem to be caught by the add-on. I think the add-on should reset the persona on unload anyway.

3.6 did this in bug 520173.

Comment 1

[Jose E. Bolanos]

Fixed:
http://hg.mozilla.org/labs/personas/rev/ec5049c0d39f

Comment 2

[Myk Melez [:myk] [@mykmelez]]

I included this in the latest development build as well as the 1.5.1rc1 build I just pushed:

https://ftp.mozilla.org/pub/mozilla.org/labs/personas/personas-dev-latest.xpi

https://ftp.mozilla.org/pub/mozilla.org/labs/personas/personas-1.5.1rc1.xpi