535941 - TryServer no longer accepts patches, wrong -p (strip dirs)

Status: RESOLVED INVALID

(Mozilla Messaging Graveyard :: Try Server, defect)

Description

[Ben Bucksch (:BenB)]

The try server no longer accepts the same patch that worked before.

Worked:
http://build.mozillamessaging.com/buildbot/try/builders/Try%20server%20comm-central%20linux%20hg%20builder/builds/270

Failed:
http://build.mozillamessaging.com/buildbot/try/builders/Try%20server%20comm-central%20linux%20hg%20builder/builds/274
with:
applying 1261186548-666-dummy.diff
unable to find 'test/ContentA.html' for patching
1 out of 1 hunks FAILED -- saving rejects to file test/ContentA.html.rej
But the file exists:
http://hg.mozilla.org/users/mozilla.BenB_bucksch.org/mail-auth/file/56c3201a13e3/suite/smile/test/ContentA.html

(I did have to update the repo to c-c between the two builds, because it failed otherwise, because m-c changed incompatibly *again*, see
http://build.mozillamessaging.com/buildbot/try/builders/Try%20server%20comm-central%20win32%20hg%20builder/builds/272 )

I tried to patch client.py instead, and it said:
unable to strip away 3 dirs from a/client.py
That sounds fishy.

Comment 1

[Ben Bucksch (:BenB)]

(Of course, could be my fault or some other variable changing again.)

Comment 2

[Ben Bucksch (:BenB)]

> unable to find 'test/ContentA.html' for patching

I should note that the patch of course contained a/suite/smile/test/ContentA.html (and it worked in build 270).

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

I believe this is no longer valid now that we have implemented try-as-branch using push to try only.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Terribly sorry, this is a messaging try bug and not Release Engineering.

Comment 5

[Philippe M. Chiasson (:gozer)]

Invalidated by push to try now.