536027 - Remove the commandDispatcher.focusedWindow hack

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: patch

The rewritten focus code in Mozilla 1.9.2 allows us to call focus() directly on the messagepane or multimessage element and have everything work correctly and the focus transferred to the child window.

Existing tests should cover everything.

Comment 1

[Rain [:rain1] (inactive)]

(consider all those dump statements removed :) )

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

This generally looks good but trying to run the full folder-display suite with or without the patch already fails down on me because of one of a yes/no prompt about deleting all the messages in a collapsed thread.  I will need to look into that unless someone else gets to it first.

Comment 3

[Rain [:rain1] (inactive)]

I'm guessing there's a problem on Linux there. Could you try it on your Windows build machine if you've been able to set it up?

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 418541 [details] [diff] [review]
patch

I do not have access to other platforms at this time and it looks like it will be another week before I get mozmill hacking time.  Please just land this at some point when you can check how our mozmill tinderboxes feel about things within 24 hours and backout if they get more angry than they already are.

Comment 5

[Rain [:rain1] (inactive)]

Since Mozmill is sort of under control now, I've decided to land this:

http://hg.mozilla.org/comm-central/rev/6e6301bf636d

Marking as in-testsuite+ because existing tests cover this.

Comment 6

[Rain [:rain1] (inactive)]

(In reply to comment #1)
> (consider all those dump statements removed :) )

clearly not :(

http://hg.mozilla.org/comm-central/rev/fe691eaa03b4