Closed Bug 536113 Opened 12 years ago Closed 12 years ago

TM: make trace-tests.py --valgrind less noisy

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

When you run trace-tests.py --valgrind you get the Valgrind start-up and shut-down messages, which makes it hard to see the results:

[176|  0|176]  49% ========================>                          |    3.9s==6211== Memcheck, a memory error detector
==6211== Copyright (C) 2002-2009, and GNU GPL'd, by Julian Seward et al.
==6211== Using Valgrind-3.5.0-Debian and LibVEX; rerun with -h for copyright info
==6211== Command: debug32/js -j -e const\ platform='linux2';\ const\ libdir='/home/njn/moz/ws2/js/src/trace-test/lib/'; -f /home/njn/moz/ws2/js/src/trace-test/lib/prolog.js -f /home/njn/moz/ws2/js/src/trace-test/tests/basic/testShiftLeft.js
==6211== 
==6211== 
==6211== HEAP SUMMARY:
==6211==     in use at exit: 0 bytes in 0 blocks
==6211==   total heap usage: 4,360 allocs, 4,360 frees, 2,092,114 bytes allocated
==6211== 
==6211== All heap blocks were freed -- no leaks are possible
==6211== 
==6211== For counts of detected and suppressed errors, rerun with: -v
==6211== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 21 from 6)
[240|  0|240]  66% =================================>                 |    8.8s==6277== Memcheck, a memory error detector
==6277== Copyright (C) 2002-2009, and GNU GPL'd, by Julian Seward et al.
==6277== Using Valgrind-3.5.0-Debian and LibVEX; rerun with -h for copyright info
==6277== Command: debug32/js -j -e const\ platform='linux2';\ const\ libdir='/home/njn/moz/ws2/js/src/trace-test/lib/'; -f /home/njn/moz/ws2/js/src/trace-test/lib/prolog.js -f /home/njn/moz/ws2/js/src/trace-test/tests/basic/testRegExpTest.js
==6277== 
==6277== 
==6277== HEAP SUMMARY:
==6277==     in use at exit: 0 bytes in 0 blocks
==6277==   total heap usage: 4,230 allocs, 4,230 frees, 1,843,659 bytes allocated
==6277== 
==6277== All heap blocks were freed -- no leaks are possible
==6277== 
==6277== For counts of detected and suppressed errors, rerun with: -v
==6277== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 21 from 6)
[300|  0|300]  83% =========================================>         |   12.9s==6339== Memcheck, a memory error detector
==6339== Copyright (C) 2002-2009, and GNU GPL'd, by Julian Seward et al.
==6339== Using Valgrind-3.5.0-Debian and LibVEX; rerun with -h for copyright info
==6339== Command: debug32/js -j -e const\ platform='linux2';\ const\ libdir='/home/njn/moz/ws2/js/src/trace-test/lib/'; -f /home/njn/moz/ws2/js/src/trace-test/lib/prolog.js -f /home/njn/moz/ws2/js/src/trace-test/tests/basic/testSideExitInConstructor.js
==6339== 
==6339== 
==6339== HEAP SUMMARY:
==6339==     in use at exit: 0 bytes in 0 blocks
==6339==   total heap usage: 4,334 allocs, 4,334 frees, 1,931,964 bytes allocated
==6339== 
==6339== All heap blocks were freed -- no leaks are possible
==6339== 
==6339== For counts of detected and suppressed errors, rerun with: -v
==6339== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 21 from 6)
[359|  0|359] 100% ==================================================>|   17.3s
PASSED ALL


The attached patch just causes Valgrind to be run with the -q option, which tells it to be quiet unless it finds an error.
Attached patch patchSplinter Review
Attachment #418593 - Flags: review?
Attachment #418593 - Flags: review? → review+
http://hg.mozilla.org/tracemonkey/rev/f740becddc56
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/f740becddc56
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.