536148 - [mozmill] Enhance tests for opening a link in a new tab (foreground / background)

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

We should enhance the Mozmill tests for the Litmus tests 8087/8088 (both 3.6) and 6045/6046 to check the correct tab opening behavior.

For 3.5 the new tabs should appear at the end of the tab bar while in 3.6 they are appended right next to the current tab.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

I have added two new files to our Litmus storage we can use for this test. Both can be found here: http://hg.mozilla.org/webtools/litmus/rev/e7d25bd82eba.

The sync will happen soon so they should appear here:
https://litmus.mozilla.org/testcase_files/firefox/tabbedbrowsing/openinnewtab.html

I will update the Litmus tests accordingly before we start with the Mozmill test. Tobbi, you wanna take it?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

All Litmus tests have been updated. Tobbi, if you want to take the bug please assign yourself.

Here some notes:
* We should have two separate patches for 1.9.2 and 1.9.1
* We will make use of the local httpd server to open the testcase files

Comment 3

[Tobias (:Tobbi) Markus]

Okay, I'm taking this and will deal with it tomorrow.

Comment 4

[Tobias (:Tobbi) Markus]

Attachment: WIP: Rewriting testOpenInBackground.js to use the httpd server

This is testOpenInBackground.js rewritten to use the new local server.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Comment on attachment 420373 [details] [diff] [review]
WIP: Rewriting testOpenInBackground.js to use the httpd server

Resetting review flag based on our conversation on IRC.

Comment 6

[Tobias (:Tobbi) Markus]

Attachment: Rewritten both tests to use the local server and improved the code structure

Current proposal of both tabs

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Comment on attachment 420899 [details] [diff] [review]
Rewritten both tests to use the local server and improved the code structure

Looks good so far. I have made some little changes like white space cleanup and removing the waitForPageLoad calls because they are not necessary when using waitForElement.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Landed for 1.9.2:
http://hg.mozilla.org/qa/mozmill-tests/rev/a42f2108669d

Tobias, can you please update the tests for 1.9.1? Please use the latest changes for that.

Comment 9

[Tobias (:Tobbi) Markus]

Attachment: enhancing tabbed browsing tests for 1.9.0 (firefox 3.5)

This should be the tests for Firefox 3.5

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Comment on attachment 421486 [details] [diff] [review]
enhancing tabbed browsing tests for 1.9.0 (firefox 3.5)

Please check the open in forground test. It fails each time. You should not close the 2nd tab but the currently selected one.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Tobbi, do you have an update for me?

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Now that bug 537330 has been landed on the 1.9.1 branch can you fix both of the tests for 1.9.1?

Comment 13

[Tobias (:Tobbi) Markus]

Attachment: Current working proposal, however, closeAllTabs(controller) doesn't seem to work

This is what seems to work with the command line interface. However, TabbedBrowsingAPI.closeAllTabs(controller) doesn't close all the tabs, but leaves the homepage tab intact whilst loading the testcase in another tab. Can anyone confirm this?

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

The patch cannot be applied. It fails. Looks like your local repository has been messed up. Please check if you really have the latest revision from the mozilla1.9.1 branch.

Comment 15

[Tobias (:Tobbi) Markus]

Attachment: This is a thing that works, however, closeAllTabs doesn't seem to close *all* the tabs, one tab remains

Comment 16

[Tobias (:Tobbi) Markus]

Attachment: testOpenInForeground.js, corrected for 3.5. This is a thing that should finally work.

I think I finally got the hang out of it. I hope it is okay that I hardcoded the number of the latest opened tab in l. 120. 

At least *this* patch passes for me all the time on 3.5.

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Comment on attachment 425190 [details] [diff] [review]
testOpenInForeground.js, corrected for 3.5. This is a thing that should finally work.

Sorry to give a r- but those tests do not use the TabbedBrowsingAPI. Please compare with the tests from the default branch for the needed updates.

Comment 18

[Tobias (:Tobbi) Markus]

Attachment: testOpenInForeground.js, Double-checked and using the new tabbedBrowsingAPI now

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Comment on attachment 425903 [details] [diff] [review]
testOpenInForeground.js, Double-checked and using the new tabbedBrowsingAPI now

(In reply to comment #18)
> Created an attachment (id=425903) [details]
> testOpenInForeground.js, Double-checked and using the new tabbedBrowsingAPI now

Sorry to bug again but what about the opening in the background test? I miss it in your patch. If you wanted to see a r+ first then you get a formal one now. Please update the patch so it includes both tests.

Comment 20

[Tobias (:Tobbi) Markus]

Attachment: All tabbed tests for 3.5

This is both open tabs tests for 3.5.

Comment 21

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Comment on attachment 425960 [details] [diff] [review]
All tabbed tests for 3.5

Thanks Tobbi. I will give r+ even when I had to do some style corrections. But what is more important I had to add another waitForPageLoad call right before the following statement. The test was failing all the time when I run the whole test folder. Please check that the next time and run all the tests.

>+  // Verify that the order of tabs is correct
>+  for each(tab in gTabOrder) {
>+    var linkId = new elementslib.ID(controller.tabs.getTab(tab.index), "id");
>+    controller.waitForElement(linkId);
>+    controller.assertText(linkId, tab.linkid);
>+  }

Comment 22

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Landed on 1.9.1 as:
http://hg.mozilla.org/qa/mozmill-tests/rev/c12efe587208

Comment 23

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.