536184 - Fails to build with libpng 1.4 betas

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Bernhard Rosenkraenzer]

User-Agent:       Mozilla/5.0 (X11; U; Linux; en-US) AppleWebKit/532.4 (KHTML, like Gecko) Arora/0.10.1 Safari/532.4
Build Identifier: Firefox 3.6b5

libpr0n/encoders/png/nsPNGEncoder.cpp fails to build with libpng 1.4 betas because png_voidp_NULL is no longer defined.

Given png_voidp_NULL has never been defined to anything but (void*)0, the obvious fix is safe and doesn't break building with older libpng versions.

Reproducible: Always

Steps to Reproduce:
1. Install libpng 1.4beta, apply apng patch
2. Configure firefox 3.6b5 for use with system libpng
3. make
Actual Results:  
Errors out

Expected Results:  
Compiles and works

Comment 1

[Bernhard Rosenkraenzer]

Attachment: Fix

Comment 2

[Glenn Randers-Pehrson]

OK except maybe better to change it to NULL instead of 0

Comment 3

[Glenn Randers-Pehrson]

(In reply to comment #2)
> OK except maybe better to change it to NULL instead of 0

Better yet, to "nsnull" along with the other NULL in the
file.

Comment 4

[Glenn Randers-Pehrson]

I will include the fix (using nsnull) in the patch to upgrade to
libpng-1.4.0 (bug #532645), which we expect to publish on January 3, 2010.

Comment 5

[Reed Loden [:reed]]

Fixed by patch in bug 532645.