Closed
Bug 536264
Opened 15 years ago
Closed 15 years ago
[OS/2] build break in modules\plugins
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: wuno, Assigned: wuno)
References
Details
Attachments
(1 file, 1 obsolete file)
|
5.90 KB,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.3a1pre) Gecko/20091221 Minefield/3.7a1pre
Build Identifier:
As a consequence of XP_OS2 not being included in the header changes of bug516509 the build breaks when compiling nsNPAPIPlugin.cpp. Fix to come up.
Reproducible: Always
|
Assignee | |
Updated•15 years ago
|
Version: unspecified → Trunk
|
|
Assignee | |
Comment 1•15 years ago
|
||
Comment on attachment 418730 [details] [diff] [review]
include XP_OS2 where appropriate
>-#if defined(XP_WIN) || defined(XP_MACOSX)
>- typedef NPError (OSCALL *NP_GetEntryPointsFunc)(NPPluginFuncs*);
>+#if defined(XP_WIN) || defined(XP_MACOSX) || defined(XP_OS2)
>+ typedef NPError (OSCALL *NP_GetEntryPointsFunc)(NPPluginFuncs*);
The second line changed here adds incorrect indentation.
Otherwise this looks fine.
Attachment #418730 -
Flags: review?(joshmoz) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
Whiteboard: attachment 419055
|
||
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: attachment 419055
Target Milestone: --- → mozilla1.9.3a1
|
|
||
Updated•15 years ago
|
Attachment #418730 -
Attachment is obsolete: true
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•