Closed Bug 536269 Opened 10 years ago Closed 10 years ago

[OS/2] build break in xpcom/build/dlldeps.cpp after fixing a win only crasher

Categories

(Core :: XPCOM, defect, major)

x86
OS/2
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: wuno, Assigned: wuno)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.3a1pre) Gecko/20091221 Minefield/3.7a1pre
Build Identifier: 

OS/2 uses the xpcom/build/dlldeps.cpp file as well as win. Several parts not used are in ifndef XP_OS2 or ifdef XP_WIN. In trying to find a top crasher on windows some new XP_WIN only code was introduced to trace the crasher. However, changes to dlldeps.cpp were put in a section os2 would try to compile as well -> break.

Reproducible: Always
Blocks: 524944
Version: unspecified → Trunk
Assignee: nobody → wuno
Status: NEW → ASSIGNED
Attachment #418731 - Flags: review?(benjamin)
Comment on attachment 418731 [details] [diff] [review]
move the new windows bits into a !XP_OS2 place

Why are you using #if !defined(XP_OS2) here, instead of #ifdef XP_WIN? The actual declaration of sXPCOMHasLoadedNewDLLs is #ifdef XP_WIN.
Attachment #418731 - Flags: review?(benjamin) → review-
(In reply to comment #2)
> (From update of attachment 418731 [details] [diff] [review])
> Why are you using #if !defined(XP_OS2) here, instead of #ifdef XP_WIN? The
> actual declaration of sXPCOMHasLoadedNewDLLs is #ifdef XP_WIN.
When you look at the whole file, there was always used !defined(XP_OS2) or ifndef XP_OS2, and actually I moved an existing !defined(XP_OS2) just two lines upwards. If you like it more, I can overhaul the whole file to use ifdef XP_WIN instead.
I've replaced all the !defined(XP_OS2) against ifdef XP_WIN, which is better readable.
Attachment #418731 - Attachment is obsolete: true
Attachment #421677 - Flags: review?(benjamin)
Attachment #421677 - Flags: review?(benjamin) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/bcbbe25e3ae2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.