Closed
Bug 536288
Opened 15 years ago
Closed 15 years ago
lirasm: test LIR_alloc more thoroughly with --random
Categories
(Core Graveyard :: Nanojit, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey)
Attachments
(1 file)
10.18 KB,
patch
|
stejohns
:
review+
|
Details | Diff | Splinter Review |
Now that the LIR stack is a bit bigger (thanks to bug 473769), lirasm --random should be able to test LIR_alloc more thoroughly. This is good because there is all sorts of special-casing for LIR_alloc. It'll need to be a bit careful because the stack still isn't all that big -- eg. we can't have the amount of stack space used increase proportionally with the block size.
As part of this, the scratch space in the stack used by --random for loads and stores should be made fixed-size, not proportional to the stack size.
![]() |
Assignee | |
Comment 1•15 years ago
|
||
The patch uses LIR_alloc a lot more. I've removed the scratch space that was being used previously, now all loads and stores are to randomly chosen LIR_alloc'd blocks.
Attachment #418763 -
Flags: review?(stejohns)
Comment 2•15 years ago
|
||
Comment on attachment 418763 [details] [diff] [review]
patch
nit: maxExplicitlyUsedtackSzB -> maxExplicitlyUsedStackSzB
Attachment #418763 -
Flags: review?(stejohns) → review+
![]() |
Assignee | |
Comment 3•15 years ago
|
||
Whiteboard: fixed-in-nanojit
![]() |
Assignee | |
Comment 4•15 years ago
|
||
Bustage fix for WinNT:
http://hg.mozilla.org/projects/nanojit-central/rev/427799622bd9
![]() |
Assignee | |
Comment 5•15 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/93b90f579db5
http://hg.mozilla.org/tracemonkey/rev/4e2f1e70bec1
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey
Comment 6•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•