lirasm: test LIR_alloc more thoroughly with --random

RESOLVED FIXED

Status

Core Graveyard
Nanojit
RESOLVED FIXED
8 years ago
4 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Now that the LIR stack is a bit bigger (thanks to bug 473769), lirasm --random should be able to test LIR_alloc more thoroughly.  This is good because there is all sorts of special-casing for LIR_alloc.  It'll need to be a bit careful because the stack still isn't all that big -- eg. we can't have the amount of stack space used increase proportionally with the block size.

As part of this, the scratch space in the stack used by --random for loads and stores should be made fixed-size, not proportional to the stack size.
(Assignee)

Updated

8 years ago
Depends on: 473769
(Assignee)

Comment 1

8 years ago
Created attachment 418763 [details] [diff] [review]
patch

The patch uses LIR_alloc a lot more.  I've removed the scratch space that was being used previously, now all loads and stores are to randomly chosen LIR_alloc'd blocks.
Attachment #418763 - Flags: review?(stejohns)

Comment 2

8 years ago
Comment on attachment 418763 [details] [diff] [review]
patch

nit: maxExplicitlyUsedtackSzB -> maxExplicitlyUsedStackSzB
Attachment #418763 - Flags: review?(stejohns) → review+
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/tracemonkey/rev/93b90f579db5
http://hg.mozilla.org/tracemonkey/rev/4e2f1e70bec1
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey

Comment 6

8 years ago
http://hg.mozilla.org/mozilla-central/rev/4e2f1e70bec1
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Component: Nanojit → Nanojit
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.