nanojit: use a bigger --random size with 'make check'

RESOLVED FIXED

Status

Core Graveyard
Nanojit
RESOLVED FIXED
8 years ago
4 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Nanojit's 'make check' currently uses the default --random size, which is a 1000 instruction block.  This should be made much bigger, to really stress things -- most of the problems I've seen with --random have only manifested with bigger sizes.

I suggest 100,000 which takes about 0.2s with a debug build on my fast Linux box.  I'd also be happy with even higher, eg. 1,000,000, esp. since the NJ tests are extremely fast anyway.
(Assignee)

Comment 1

8 years ago
Created attachment 420225 [details] [diff] [review]
patch

I upped it to 1,000,000.  If we can let the machine do the work, we might as well really stress it.  (Motivation for doing this now is that we just found a lirasm assert that wasn't being triggered with smaller random sizes.)
Attachment #420225 - Flags: review?(stejohns)

Updated

8 years ago
Attachment #420225 - Flags: review?(stejohns) → review+
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/projects/nanojit-central/rev/759fd4ffc918

Note that this change doesn't need to be merged to TM and TR because it only affects the NJ-central build system.  So I'm marking it as closed.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-nanojit
(Assignee)

Comment 3

8 years ago
There's also the testlirc.sh script, which is used in the TM copy.  I updated that as well:

http://hg.mozilla.org/projects/nanojit-central/rev/3f09056fb0a7

Reopening bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/tracemonkey/rev/1b5cc64a1bc6
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/mozilla-central/rev/1b5cc64a1bc6
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
Component: Nanojit → Nanojit
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.