536352 - missed null check and memory leak

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[u367160]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.16) Gecko/2009121601 Ubuntu/8.10 (intrepid) Firefox/3.0.16 GTB6
Build Identifier: 

in code of latest trunk http://hg.mozilla.org/mozilla-central:

in file config/nsinstall.c 264:
dir should be null checked because opendir function may return null.

in the same function destdir should be freed before return.

Reproducible: Always

Comment 1

[u367160]

Attachment: proposed patch to fix

proposed patch to fix the null check and memory leak issue

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 418837 [details] [diff] [review]
proposed patch to fix

>diff -r 1f0e04dc2b21 config/nsinstall.c
>--- a/config/nsinstall.c	Tue Dec 22 09:47:18 2009 +0000
>+++ b/config/nsinstall.c	Tue Dec 22 13:07:58 2009 +0200
>@@ -256,17 +256,21 @@ copydir( char *from, char *to, mode_t mo
>   /* create destination directory */
>   destdir = xmalloc((unsigned int)(strlen(to) + 1 + strlen(base) + 1));
>   sprintf(destdir, "%s%s%s", to, _DIRECTORY_SEPARATOR, base);
>   if (mkdirs(destdir, mode) != 0) {
>     fail("cannot make directory %s\n", destdir);
>     return;

You should probably put a free(destdir) in here for consistency.

Otherwise looks fine. If you attach a patch with that change I'll land it for you.

Comment 3

[u367160]

Attachment: proposed patch to fix

patch updated as required, thanks for reviewing

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

http://hg.mozilla.org/mozilla-central/rev/1aa561085c31

Comment 5

[Wolfgang Rosenauer [:wolfiR]]

I forgot to sync with js/src/config initially:
http://hg.mozilla.org/mozilla-central/rev/586eea23fcef