URL in mailWindowOverlay.xul needs to be localized

VERIFIED FIXED in mozilla0.9

Status

MailNews Core
Localization
P3
normal
VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: Allan Masri, Assigned: tao)

Tracking

({l12y})

Trunk
mozilla0.9

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta1+ 2/21]fix ready, URL)

Attachments

(3 attachments)

(Reporter)

Description

18 years ago
in line #704 of mailWindowOverlay.xul, there is a bare URL:

oncommand="openTopWin('http://search.netscape.com/')"

This URL will only work with english versions of Mozilla. It needs to be
tokenized and redirected to a dtd file in the language pack.

Comment 1

18 years ago
nominating for rtm, though I know it's late...
Keywords: rtm

Comment 2

18 years ago
This is the Menu item, "Search | Search the web".
There is Japanese content available for this link at
Netcenter. 

Comment 3

18 years ago
msanz, will this actually get localized?  I thought it was too late for that.

If it won't get localized for the I18N RTMs, I don't think it's an RTM bug.
Whiteboard: [need info]

Comment 4

18 years ago
It should be localized in a dtd file (or any other kind of file that contains
URLs). In any case, I realize it is too late, so we will go ahead and localize
this directly in the xul file. Not something that I like, but we'll live with
it. I'd like to mark this bug for the next release, can you do so?

Comment 5

18 years ago
Adding mail3 keyword so it will show up on the radar for the next release.
Keywords: mail3

Comment 6

18 years ago
Are we sure that there is no more cycle in L10n to change the URL
if it is extracted?

Comment 7

18 years ago
rtm- based on prior comments.
Whiteboard: [need info] → [rtm-]

Comment 8

18 years ago
reassigning to sspitzer
Assignee: putterman → sspitzer

Comment 9

17 years ago
adding localizability keyword
Keywords: l12y

Comment 10

17 years ago
adding nsbeta1 keyword to localizability bugs
Keywords: nsbeta1

Comment 11

17 years ago
marking nsbeta1+ and moving to mozilla0.8
Keywords: rtm
Whiteboard: [rtm-] → [nsbeta1+]
Target Milestone: --- → mozilla0.8

Comment 12

17 years ago
reassigning to ssu
Assignee: sspitzer → ssu

Comment 13

17 years ago
QA contact to ji.
QA Contact: momoi → ji

Comment 14

17 years ago
moving to mozilla0.9
Target Milestone: mozilla0.8 → mozilla0.9

Comment 15

17 years ago
marking nsbeta1- and moving to future milestone.
Keywords: nsbeta1 → nsbeta1-
Whiteboard: [nsbeta1+] → [nsbeta1+ 2/21]
Target Milestone: mozilla0.9 → Future

Comment 16

17 years ago
removing the minus; Scott, we need this bug fixed to have all localized
resources in lang packs and not in xul file. Do you need help? This has to be
fixed in the beta. 
Keywords: nsbeta1- → nsbeta1

Comment 17

17 years ago
Yes I need help.  If there's someone you can reassign this to on the l10n team, 
that would be appreciated.

Comment 18

17 years ago
Michele, can Ray help with this  one? we need this fixed for beta. Please, check
with him and reassign as needed.
(Assignee)

Comment 19

17 years ago
Please move it chrome//messenger-region/locale/region.{dtd,properties}
in US.jar.

Comment 20

17 years ago
ssu, please let me know if you need any help. Thanks.

Comment 21

17 years ago
yes, he needs help. Can you work in the bug? If so, please reassign to you and
give Ssu the files to check them in when ready. Modify bug as needed.

Comment 22

17 years ago
yes, I can definitely use your help Ray.

Comment 23

17 years ago
I will look into this issue and get back to you later.

Comment 24

17 years ago
ssu, do you know how to verify the bug from the user point of view?

Comment 25

17 years ago
sorry, but I do not.  I believe that Tao might.

Comment 26

17 years ago
Allan, Ji, 

Do you have any idea?

Comment 27

17 years ago
Select Menu Search | Search the Web should go to the URL in the corresponding lang pack.
 It can be verified with a localized build or a US build with a lang pack for a language 
other than English.

Comment 28

17 years ago
Hmm, selecting the menu goes to a different URL. I wonder what mailWindowOverlay.xul is for.

Comment 29

17 years ago
You were right, Ji. The URL has been changed to 
"http://home.netscape.com/bookmark/6_0/ssearch.html"

Lynn, Christine,

Do you have the URL for Ja? The URL is placed at mail | Menu Search | Search the 
Web. 

Comment 30

17 years ago
Actually, Search the Web in Navigator used to be controlled by 
navigatorOverlay.xul. The string was <menuitem value="&searchInternetCmd.label;" 
accesskey="&searchInternetCmd.accesskey;" 
oncommand="openTopWin('http://home.netscape.com/ja/escapes/internet_search.html 
')"/>, but this was changed after RTM. I would assume the same has happened to 
the mailWindowOverlay.xul. In any case, the correct URL is 
http://home.netscape.com/ja/escapes/internet_search.html for the Japanese 
search.

Comment 31

17 years ago
Where do you find mailWindowOverlay.xul? I haven't seen this file anywhere in 
20010131 builds.

Comment 32

17 years ago
It is still in messenger.jar.

Comment 33

17 years ago
Thanks! I see it in the DE: 	<menuitem value="&searchInternetCmd.label;" 
accesskey="&searchInternetCmd.accesskey;" 
oncommand="openTopWin('http://home.netscape.com/de/escapes/internet_search.html'
)"/>

Comment 34

17 years ago
navigatorOverlay.xul now says <menuitem value="&searchInternetCmd.label;" 
accesskey="&searchInternetCmd.accesskey;" 
oncommand="loadXURL('urn:clienturl:srchmenu:srchinternet');"/>. Where do I find 
loadXURL?

Comment 35

17 years ago
there is a way to verify it and you don't need a localized build or a localized
URl for that, you just need to make sure that the URL is in a dtd (or rdf or
wherever it belongs) instead of a xul file. Just outsource the URL and then make
any change to the URL in the text file. If it changes in the product it's fixed,
if it doesn't it's not.

Comment 36

17 years ago
Created attachment 26465 [details]
region.dtd is a new file under messenger-region

Comment 37

17 years ago
Created attachment 26466 [details]
The URL in mailWindowOverlay.xul has been extracted to region.dtd.

Comment 38

17 years ago
The fix is ready. 

Two files were attached: region.dtd and mailWindowOverlay.xul. Region.dtd is a 
new file and should go to the folder messenger-region/locale in US.jar.

ssu, plrease review them and checkin. If you have any question, please let me 
know.
(Assignee)

Comment 39

17 years ago
Hi, Ray:

In searching the url (for search), I found that it is defined in builtinURLs.rdf.
In this case, I'd suggest that we follow the same fashion in navigator
to avoid introducing a new file. Please refer to
http://lxr.mozilla.org/mozilla/source/xpfe/browser/resources/content/navigatorOverlay.xul#270

for this is done. 

Sorry for the last minute finding. thx!

Comment 40

17 years ago
Tao, why don't you give ssu the files the way you suggested. It will much easier 
and less confusing. Thanks.

Comment 41

17 years ago
Sorry about that, guys! I saw the URL in the builtinURLs.rdf today, too. It's 
the one in the communicator directory (not global).
(Assignee)

Comment 42

17 years ago
Created attachment 26486 [details] [diff] [review]
shared the link in builtinURLs.rdf instead of introducing new one/file.
(Assignee)

Comment 43

17 years ago
Hi, reviewers:

Please discard previous two patches and review this one, 
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=26486, instead. 

thx
(Assignee)

Comment 44

17 years ago
Hi, Sean:

Would you verify that the above patch work for you? It works for me; but, just
wanna be cautious.

thx

Comment 45

17 years ago
reassigning to tao and cc'ing chuang.

Candice, could you do a review for this patch?
Assignee: ssu → tao
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Whiteboard: [nsbeta1+ 2/21] → [nsbeta1+ 2/21]pending review...
(Assignee)

Comment 46

17 years ago
Hi, Scott:

I am reassigning this bug to you giving that the patch is provided. Please
get r/sr from your staff and checked it in or reassign back me.

thx
Assignee: tao → putterman
Status: ASSIGNED → NEW

Comment 47

17 years ago
r=chuang. 

Comment 48

17 years ago
Tao, once you get the sr=, feel free to check it in.  Thanks for fixing this.
Assignee: putterman → tao
sr=sspitzer

make sure you test the 3 pane and the stand alone message window
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Keywords: patch
Whiteboard: [nsbeta1+ 2/21]pending review... → [nsbeta1+ 2/21]fix ready
(Assignee)

Updated

17 years ago
Keywords: patch
Target Milestone: Future → mozilla0.9
(Assignee)

Comment 50

17 years ago
fix should appear in today's build.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 51

17 years ago
Verified with Ja beta1 build. It's fixed.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.