Closed Bug 53638 Opened 24 years ago Closed 23 years ago

URL in mailWindowOverlay.xul needs to be localized

Categories

(MailNews Core :: Localization, defect, P3)

Product:
MailNews Core
Component:
Localization
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9

People

(Reporter: amasri, Assigned: tao)

References

(
URL
)

Details

(Keywords: l12y, Whiteboard: [nsbeta1+ 2/21]fix ready)

Attachments

(3 files)

region.dtd is a new file under messenger-region
112 bytes, text/plain
Details
The URL in mailWindowOverlay.xul has been extracted to region.dtd.
60.39 KB, text/plain
Details
shared the link in builtinURLs.rdf instead of introducing new one/file.
1.52 KB, patch
Details | Diff | Splinter Review 
in line #704 of mailWindowOverlay.xul, there is a bare URL:

oncommand="openTopWin('http://search.netscape.com/')"

This URL will only work with english versions of Mozilla. It needs to be
tokenized and redirected to a dtd file in the language pack.
nominating for rtm, though I know it's late...
Keywords: rtm
This is the Menu item, "Search | Search the web".
There is Japanese content available for this link at
Netcenter. 
msanz, will this actually get localized?  I thought it was too late for that.

If it won't get localized for the I18N RTMs, I don't think it's an RTM bug.
Whiteboard: [need info]
It should be localized in a dtd file (or any other kind of file that contains
URLs). In any case, I realize it is too late, so we will go ahead and localize
this directly in the xul file. Not something that I like, but we'll live with
it. I'd like to mark this bug for the next release, can you do so?
Adding mail3 keyword so it will show up on the radar for the next release.
Keywords: mail3
Are we sure that there is no more cycle in L10n to change the URL
if it is extracted?
rtm- based on prior comments.
Whiteboard: [need info] → [rtm-]
reassigning to sspitzer
Assignee: putterman → sspitzer
adding localizability keyword
Keywords: l12y
adding nsbeta1 keyword to localizability bugs
Keywords: nsbeta1
marking nsbeta1+ and moving to mozilla0.8
Keywords: rtm
Whiteboard: [rtm-] → [nsbeta1+]
Target Milestone: --- → mozilla0.8
reassigning to ssu
Assignee: sspitzer → ssu
QA contact to ji.
QA Contact: momoi → ji
moving to mozilla0.9
Target Milestone: mozilla0.8 → mozilla0.9
marking nsbeta1- and moving to future milestone.
Keywords: nsbeta1 → nsbeta1-
Whiteboard: [nsbeta1+] → [nsbeta1+ 2/21]
Target Milestone: mozilla0.9 → Future
removing the minus; Scott, we need this bug fixed to have all localized
resources in lang packs and not in xul file. Do you need help? This has to be
fixed in the beta.
Keywords: nsbeta1- → nsbeta1
Yes I need help.  If there's someone you can reassign this to on the l10n team, 
that would be appreciated.
Michele, can Ray help with this  one? we need this fixed for beta. Please, check
with him and reassign as needed.
Please move it chrome//messenger-region/locale/region.{dtd,properties}
in US.jar.
ssu, please let me know if you need any help. Thanks.
yes, he needs help. Can you work in the bug? If so, please reassign to you and
give Ssu the files to check them in when ready. Modify bug as needed.

yes, I can definitely use your help Ray.
I will look into this issue and get back to you later.
ssu, do you know how to verify the bug from the user point of view?
sorry, but I do not.  I believe that Tao might.
Allan, Ji, 

Do you have any idea?
Select Menu Search | Search the Web should go to the URL in the corresponding lang pack.
 It can be verified with a localized build or a US build with a lang pack for a language 
other than English.
Hmm, selecting the menu goes to a different URL. I wonder what mailWindowOverlay.xul is for.
You were right, Ji. The URL has been changed to 
"http://home.netscape.com/bookmark/6_0/ssearch.html"

Lynn, Christine,

Do you have the URL for Ja? The URL is placed at mail | Menu Search | Search the 
Web. 
Actually, Search the Web in Navigator used to be controlled by 
navigatorOverlay.xul. The string was <menuitem value="&searchInternetCmd.label;" 
accesskey="&searchInternetCmd.accesskey;" 
oncommand="openTopWin('http://home.netscape.com/ja/escapes/internet_search.html 
')"/>, but this was changed after RTM. I would assume the same has happened to 
the mailWindowOverlay.xul. In any case, the correct URL is 
http://home.netscape.com/ja/escapes/internet_search.html for the Japanese 
search.
Where do you find mailWindowOverlay.xul? I haven't seen this file anywhere in 
20010131 builds.
It is still in messenger.jar.
Thanks! I see it in the DE: 	<menuitem value="&searchInternetCmd.label;" 
accesskey="&searchInternetCmd.accesskey;" 
oncommand="openTopWin('http://home.netscape.com/de/escapes/internet_search.html'
)"/>

navigatorOverlay.xul now says <menuitem value="&searchInternetCmd.label;" 
accesskey="&searchInternetCmd.accesskey;" 
oncommand="loadXURL('urn:clienturl:srchmenu:srchinternet');"/>. Where do I find 
loadXURL?
there is a way to verify it and you don't need a localized build or a localized
URl for that, you just need to make sure that the URL is in a dtd (or rdf or
wherever it belongs) instead of a xul file. Just outsource the URL and then make
any change to the URL in the text file. If it changes in the product it's fixed,
if it doesn't it's not.
The fix is ready. 

Two files were attached: region.dtd and mailWindowOverlay.xul. Region.dtd is a 
new file and should go to the folder messenger-region/locale in US.jar.

ssu, plrease review them and checkin. If you have any question, please let me 
know.
Hi, Ray:

In searching the url (for search), I found that it is defined in builtinURLs.rdf.
In this case, I'd suggest that we follow the same fashion in navigator
to avoid introducing a new file. Please refer to
http://lxr.mozilla.org/mozilla/source/xpfe/browser/resources/content/navigatorOverlay.xul#270

for this is done. 

Sorry for the last minute finding. thx!

Tao, why don't you give ssu the files the way you suggested. It will much easier 
and less confusing. Thanks.
Sorry about that, guys! I saw the URL in the builtinURLs.rdf today, too. It's 
the one in the communicator directory (not global).
Hi, reviewers:

Please discard previous two patches and review this one, 
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=26486, instead. 

thx
Hi, Sean:

Would you verify that the above patch work for you? It works for me; but, just
wanna be cautious.

thx
reassigning to tao and cc'ing chuang.

Candice, could you do a review for this patch?
Assignee: ssu → tao
Status: NEW → ASSIGNED
Whiteboard: [nsbeta1+ 2/21] → [nsbeta1+ 2/21]pending review...
Hi, Scott:

I am reassigning this bug to you giving that the patch is provided. Please
get r/sr from your staff and checked it in or reassign back me.

thx
Assignee: tao → putterman
Status: ASSIGNED → NEW
r=chuang. 
Tao, once you get the sr=, feel free to check it in.  Thanks for fixing this.
Assignee: putterman → tao
sr=sspitzer

make sure you test the 3 pane and the stand alone message window
Status: NEW → ASSIGNED
Keywords: patch
Whiteboard: [nsbeta1+ 2/21]pending review... → [nsbeta1+ 2/21]fix ready
Keywords: patch
Target Milestone: Future → mozilla0.9
fix should appear in today's build.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Verified with Ja beta1 build. It's fixed.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: