536388 - cleanup code in harnesses, make a few parts more OO

Status: RESOLVED DUPLICATE of bug 688667

(Testing :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

after all the changes for adding remote testing (as well as months of other various changes), we have some code that could use some cleanup.

Specifically:
 - build/automation.py.in.__all__: this works as it does before migrating to a class, but we need to consider moving it out of the class and just exposing the class 'Automation'
 - build/automation.py.in.runApp(...): now that this is in a class, can we reduce the large list of parameters by using class members?  These would need to be defined during the __init__() call or after options are read via the cli
 - addCommonOptions(): we iterate over automation.__all__ to set defaults for the addCommonOptions.  We also are using classes for cli parameters so we can revisit this and make it cleaner.

Comment 1

[Jeff Hammel]

maybe worth adding to the mozbase effort?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Actually I think the mozbase efforts will replace the need for a lot of this.  This bug originally pointed out the need for better command line option handling as it was sort of sloppy between 3 different files.  Removing automation.py and automationutils.py and making these reference common modules (i.e. mozprocess, mozprofile, mozinfo) will help a lot.

I am inclined to close this bug as a dup of the mozbase stuff.

Comment 3

[Jeff Hammel]

I'm fine with closing or moving to bug 688667

Comment 4

[cmtalbert]

(In reply to Jeff Hammel [:jhammel] from comment #3)
> I'm fine with closing or moving to bug 688667

Sounds like we should do it then. :)