536463 - Fix warning: ‘virtual nsresult nsBox::GetMargin(nsMargin&)’ was hidden [...] by ‘void nsTableOuterFrame::GetMargin

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: trivial fix: s/GetMargin/GetTableMargin/

With g++ 4.3, I get this build warning when compiling mozilla-central:

> ../../../mozilla/layout/base/../xul/base/src/nsBox.h:74: warning: ‘virtual nsresult nsBox::GetMargin(nsMargin&)’ was hidden
> ../../../mozilla/layout/base/../tables/nsTableOuterFrame.h:270: warning: by ‘void nsTableOuterFrame::GetMargin(nsPresContext*, const nsHTMLReflowState&, nsIFrame*, nscoord, nsMargin&)’

Turns out the guilty function (nsTableOuterFrame::GetMargin) is only called in one place anyway.  Simple fix: rename this method to GetTableMargin.

(Similar to bug 508692)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 418906 [details] [diff] [review]
trivial fix: s/GetMargin/GetTableMargin/

r=dbaron if you call it GetChildMargin instead.  (GetTableMargin can be confusing since the outer table often refers to the inner table as the table.  The one caller looks like it calls the function on both children of the outer table:  the inner table and the caption.)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: trivial fix: s/GetMargin/GetChildMargin/

Good point.  Changed to GetChildMargin in this version.  Thanks!

Comment 3

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/mozilla-central/rev/824e6be7a972