Arguments to nsLoadGroup::RemoveRequest in imgRequestProxy::RemoveFromLoadGroup are flipped

RESOLVED FIXED

Status

()

Core
ImageLib
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: tnikkel, Assigned: tnikkel)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

907 bytes, patch
Joe Drew (not getting mail)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
http://mxr.mozilla.org/mozilla-central/source/modules/libpr0n/src/imgRequestProxy.cpp#194

  mLoadGroup->RemoveRequest(this, nsnull, NS_OK);

but the method is

  nsLoadGroup::RemoveRequest(nsIRequest *request, nsISupports* ctxt,
                             nsresult aStatus)

It doesn't cause any problem because nsnull "is 0" and so is NS_OK.

Patch coming up.
(Assignee)

Comment 1

8 years ago
Created attachment 418959 [details] [diff] [review]
patch
Assignee: nobody → tnikkel
Attachment #418959 - Flags: review?(joe)
Comment on attachment 418959 [details] [diff] [review]
patch

now I know why this caused me so much trouble when I tried reviewing it before - the code you pasted into comment 0 was already correct, which confused me. :)

r+ so hard.
Attachment #418959 - Flags: review?(joe) → review+
(Assignee)

Comment 3

8 years ago
Whoops, sorry about that.
(Assignee)

Comment 4

8 years ago
Landed
http://hg.mozilla.org/mozilla-central/rev/c51c93f5240f

but backed out because something in the push is causing orange
http://hg.mozilla.org/mozilla-central/rev/01befa5163ee
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/mozilla-central/rev/26047e06795a
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.