Closed Bug 536495 Opened 10 years ago Closed 10 years ago

Arguments to nsLoadGroup::RemoveRequest in imgRequestProxy::RemoveFromLoadGroup are flipped

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: tnikkel, Assigned: tnikkel)

Details

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/source/modules/libpr0n/src/imgRequestProxy.cpp#194

  mLoadGroup->RemoveRequest(this, nsnull, NS_OK);

but the method is

  nsLoadGroup::RemoveRequest(nsIRequest *request, nsISupports* ctxt,
                             nsresult aStatus)

It doesn't cause any problem because nsnull "is 0" and so is NS_OK.

Patch coming up.
Attached patch patchSplinter Review
Assignee: nobody → tnikkel
Attachment #418959 - Flags: review?(joe)
Comment on attachment 418959 [details] [diff] [review]
patch

now I know why this caused me so much trouble when I tried reviewing it before - the code you pasted into comment 0 was already correct, which confused me. :)

r+ so hard.
Attachment #418959 - Flags: review?(joe) → review+
Whoops, sorry about that.
Landed
http://hg.mozilla.org/mozilla-central/rev/c51c93f5240f

but backed out because something in the push is causing orange
http://hg.mozilla.org/mozilla-central/rev/01befa5163ee
http://hg.mozilla.org/mozilla-central/rev/26047e06795a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.