536495 - Arguments to nsLoadGroup::RemoveRequest in imgRequestProxy::RemoveFromLoadGroup are flipped

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Timothy Nikkel (:tnikkel)]

http://mxr.mozilla.org/mozilla-central/source/modules/libpr0n/src/imgRequestProxy.cpp#194

  mLoadGroup->RemoveRequest(this, nsnull, NS_OK);

but the method is

  nsLoadGroup::RemoveRequest(nsIRequest *request, nsISupports* ctxt,
                             nsresult aStatus)

It doesn't cause any problem because nsnull "is 0" and so is NS_OK.

Patch coming up.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Comment 2

[Joe Drew (not getting mail)]

Comment on attachment 418959 [details] [diff] [review]
patch

now I know why this caused me so much trouble when I tried reviewing it before - the code you pasted into comment 0 was already correct, which confused me. :)

r+ so hard.

Comment 3

[Timothy Nikkel (:tnikkel)]

Whoops, sorry about that.

Comment 4

[Timothy Nikkel (:tnikkel)]

Landed
http://hg.mozilla.org/mozilla-central/rev/c51c93f5240f

but backed out because something in the push is causing orange
http://hg.mozilla.org/mozilla-central/rev/01befa5163ee

Comment 5

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/mozilla-central/rev/26047e06795a