Closed Bug 536588 Opened 12 years ago Closed 12 years ago

Build warning: "can't read ../mozilla/dom/ipc/Makefile.in: No such file or directory"

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(1 file)

When building mozilla-central, I get the following output:
{
creating ipc/ipdl/Makefile
creating ipc/testshell/Makefile
can't read ../mozilla/ipc/testshell/Makefile.in: No such file or directory
creating dom/Makefile
[...]
creating dom/plugins/Makefile
creating dom/ipc/Makefile
can't read ../mozilla/dom/ipc/Makefile.in: No such file or directory
}

The directories that can't be read (ipc/testshell and dom/ipc) don't actually exist in our source tree, as shown by these MXR urls:
  http://mxr.mozilla.org/mozilla-central/source/ipc/testshell
  http://mxr.mozilla.org/mozilla-central/source/dom/ipc

However, these nonexistent directories are referred to in toolkit-makefiles.sh:
50 MAKEFILES_dom="
[...]
55   ipc/testshell/Makefile
[...]
89   dom/ipc/Makefile
90 "

Those were added in this changeset:
http://hg.mozilla.org/mozilla-central/diff/17c4987e08e3/toolkit/toolkit-makefiles.sh

bsmedberg, is there any reason that those are there?
There are there because of a merge from e10s, where those directories are present. It doesn't much matter to me, but you can remove those lines from m-c if you want.
Attached patch trivial fixSplinter Review
Ok -- attaching fix.  From comment 1, it sounds like this is effectively already r=bsmedberg, but I'm requesting review just to be safe.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #420268 - Flags: review?
Attachment #420268 - Flags: review? → review?(benjamin)
Actually, I just landed with "blanket-r=ted", per philor's logic in bug 538090 comment 4 (and with implicit r=bsmedberg from comment 1)
http://hg.mozilla.org/mozilla-central/rev/e84bf35fdd42

Resolving.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment #420268 - Flags: review?(benjamin)
You need to log in before you can comment on or make changes to this bug.