nsJPEGEncoder::errorExit incorrectly reports JERR_OUT_OF_MEMORY as NS_ERROR_FAILURE instead of NS_ERROR_OUT_OF_MEMORY

RESOLVED FIXED in mozilla1.9.3a3

Status

()

Core
ImageLib
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Ehren Metcalfe, Assigned: Ehren Metcalfe)

Tracking

(Blocks: 1 bug)

unspecified
mozilla1.9.3a3
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

708 bytes, patch
Joe Drew (not getting mail)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
Created attachment 419083 [details] [diff] [review]
add break

There appears to be a missing break statement in nsJPEGEncoder::errorExit which will will never allow reporting an NS_ERROR_OUT_OF_MEMORY error. Incidentally, this was discovered using an analysis to check for dead basic blocks (this function's dead block, the exit, is legitimate).
(Assignee)

Updated

8 years ago
Attachment #419083 - Flags: review?(joe)
Assignee: nobody → ehren.m
Comment on attachment 419083 [details] [diff] [review]
add break

I'm ok with us not having a test for this bug - it's really hard to simulate out of memory reliably.
Attachment #419083 - Flags: review?(joe) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/f064bcba96c3
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a3
You need to log in before you can comment on or make changes to this bug.