536651 - IPDL generates unreachable statements

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Ehren Metcalfe]

This is a generated file so I can't post a link but PPluginInstanceChild.cpp contains a number of statements of the form:

return 0;
(mManagedPStreamNotifyChild).RemoveElementSorted(actor);

These can be found in CallPStreamNotifyConstructor on lines 502 and 515

Also in CallPPluginScriptableObjectConstructor on lines 651 and 665

And in CallPPluginStreamConstructor on lines 728 and 741

This was discovered using the analysis in bug 535646. Please excuse me if these were somehow intentional.

Comment 1

[Ehren Metcalfe]

The same pattern also exists in PTestArraysParent.cpp:

return 0;
(mManagedPTestArraysSubParent).RemoveElementSorted(actor);

found in

PTestArraysParent::SendPTestArraysSubConstructor line 121

And in PPluginInstanceParent.cpp:

return 0;
(mManagedPPluginScriptableObjectParent).RemoveElementSorted(actor);

found in

PPluginInstanceParent::CallPPluginScriptableObjectConstructor on line 426 and 439

Also in PPluginModuleParent.cpp

return 0;
(mManagedPPluginInstanceParent).RemoveElementSorted(actor);

found in PPluginModuleParent::CallPPluginInstanceConstructor on line 155 and 168

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

This is an IPDL problem. It's generating bad code.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This was the bug that led me to file bug 535646 in the first place ;).

It was fixed by http://hg.mozilla.org/projects/electrolysis/rev/0e3ed118aedd