536667 - Thunderbird 2 app.update.url needs updating to supply OS version information to aus

Status: VERIFIED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mark Banner (:standard8)]

AUS is now capable of not offering major updates to Thunderbird 2.0.0.x users that are on unsupported platforms. Unfortunately Thunderbird 2 doesn't supply enough information to AUS for AUS to determine this.

Thunderbird 2 example app.update.url:

https://aus2.mozilla.org/update/1/Thunderbird/2.0.0.23/2009081209/Linux_x86-gcc3/en-US/betatest/update.xml?force=1

This is a version "1" url. Version 2 (which Firefox used on 1.8.1.x) would give us something like:

https://aus2.mozilla.org/update/2/Thunderbird/2.0.0.23/2009081209/Linux_x86-gcc3/en-US/betatest/Linux%202.6.18-8.el5%20(GTK%202.10.4)/update.xml?force=1

This currently returns a major update offer as GTK 2.10 is supported.

On an unsupported system (e.g. GTK 2.9.x):

https://aus2.mozilla.org/update/2/Thunderbird/2.0.0.23/2009081209/Linux_x86-gcc3/en-US/betatest/Linux%202.6.18-8.el5%20(GTK%202.9.0)/update.xml?force=1

This returns no update offer.

The patch is simple and low risk, but we need a .24 so we can correct our offerings hence requesting blocking. This also should block an offering of a major update (hence blocking bug 534180 which is one of the update offer blocking bugs).

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix

This upgrades the app.update.url to version 2 which is the same as FF 2.0 used. It adds the OS Version field into the url which is what we need to supply to AUS to fix the bug.

(version 3 of the url adds distribution version information, which we don't need for the 2.x builds).

I tested this on a Mac version of 2.x by manually applying the patch and having "app.update.log.Checker" set to true in my prefs and then looking at the error console to check the url of the request. With the patch applied it correctly had the OS version included.

Comment 2

[David :Bienvenu]

Comment on attachment 419888 [details] [diff] [review]
The fix

this looks to be the right thing to do...

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 419888 [details] [diff] [review]
The fix

Requesting branch approval. Low risk patch, any bad effects should be immediately obvious.

Needed to allow Thunderbird 3 to push a major upgrade without incorrectly updating users on OS versions that are no longer supported.

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 419888 [details] [diff] [review]
The fix

Approved for 1.8.1.24, a=dveditz for release-drivers

Comment 5

[Mark Banner (:standard8)]

Checked into 1.8 branch:

Checking in mail/app/profile/all-thunderbird.js;
/cvsroot/mozilla/mail/app/profile/all-thunderbird.js,v  <--  all-thunderbird.js
new revision: 1.44.2.48; previous revision: 1.44.2.47

Comment 6

[Al Billings [:abillings - ex-MoCo]]

Ludovic, do you want to verify this one for Mozilla Messaging's happiness?

Comment 7

[Ludovic Hirlimann [:Usul]]

Sure will do