Closed Bug 536725 Opened 15 years ago Closed 14 years ago

Disable SSE1 code on Windows x64

Categories

(Core :: Graphics: Color Management, defect)

Product:
Core
Component:
Graphics: Color Management
Platform:
x86_64
Windows Vista
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

patch v1
1.76 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review 
Microsoft Visual C++ compiler for x64 doesn't support MMX instruction set, and x64 mode supports SSE2 instruction set by default.

So we don't include SSE transform code on x64 Windows build because transform-sse1.c uses __m64 (MMX register).
Assignee: nobody → m_kato
Blocks: tracking_win64
Attached patch patch v1 — — Splinter Review 

    
  

        Attachment #419156 -
        Flags: review?(jmuizelaar)

    
    

    
  
Comment on attachment 419156 [details] [diff] [review]
patch v1

It would be nice if this was a little cleaner, but I can't come up with a great way to do that. Can you at least add a comment near the transform.c ifdef that explains why it's there.

        Attachment #419156 -
        Flags: review?(jmuizelaar) → review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/f57b95afb57e
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: