Closed Bug 536789 Opened 12 years ago Closed 12 years ago
crashes [@ Get
Crashes at GetBodyColor started showing up in 2009-12-25 builds, presumably a regression from bug 500882. http://crash-stats.mozilla.com/report/list?range_value=2&range_unit=weeks&signature=GetBodyColor&version=Firefox%3A3.7a1pre has more details Looks like a null-dereference (crash address is always 0x14). Stacks look a bit confused in crash-stats, but top 3 frames seem to make sense at first glance: 0 xul.dll GetBodyColor layout/style/nsHTMLStyleSheet.cpp:413 1 xul.dll nsHTMLStyleSheet::RulesMatching 2 xul.dll EnumRulesMatching<ElementRuleProcessorData> layout/style/nsStyleSet.cpp:419
> Looks like a null-dereference (crash address is always 0x14). Yep, that's GetPrimaryFrame on a null content.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #419205 - Flags: review?(dbaron)
Comment on attachment 419205 [details] [diff] [review] Fix r=dbaron I suspect the color of the document when it's a frameset never actually shows up, so we could just use GetBodyContent.
Attachment #419205 - Flags: review?(dbaron) → review+
Pushed http://hg.mozilla.org/mozilla-central/rev/f428c74b2326 with that change.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.