commonDialogOnOK() doesn't set param var

VERIFIED WONTFIX

Status

SeaMonkey
UI Design
P3
normal
VERIFIED WONTFIX
18 years ago
10 years ago

People

(Reporter: Matthew Cline, Assigned: Ben Goodger (use ben at mozilla dot org for email))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
The param variable is commonDialogOnOK() isn't set.  I fixed this by a
cut-and-paste from another area of the commonDialog.js file; will attach
fix.
(Reporter)

Comment 1

18 years ago
Created attachment 15299 [details] [diff] [review]
Declare and set param in commonDialogOnOK()
(Reporter)

Comment 2

18 years ago
Re-assining component to XP Apps; hope that's where this goes.
Component: Browser-General → XP Apps

Comment 3

18 years ago
really reassigning it
Assignee: asa → don
QA Contact: doronr → sairuh
Component: XP Apps → XP Apps: GUI Features
QA Contact: sairuh → jrgm

Comment 4

18 years ago
If a var is not scoped locally in JS, then it has global scope. So doing the QI 
a second time is redundant, no?

It is of course better practice to declare your globals as such (add 
'var param;' at the top of commonDialog.js) and that would suppress 
any warnings if running with the JS strict option.
Since Don has left, Vishy is taking his bugs in bulk, pending reassignment.
thanks,
	Vishy
Assignee: don → vishy
get patch reviewed etc and checked in if correct. 
Assignee: vishy → ben

Updated

18 years ago
Keywords: approval, patch, review

Comment 7

18 years ago
Hello Matt, you still there? is this bug still relevant?

Comment 8

18 years ago
alecf in rev 1.29 of commonDialog.js (bug 58931) made 'param' clearer
by changing it to gCommonDialogParam, to make it clear it was global
in scope (and cleaned up a bunch of other warnings). This patch is 
now redundant. Marking WONTFIX (nothing left to fix). 
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → WONTFIX

Comment 9

18 years ago
This much I know :-]
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite

Updated

10 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.