The param variable is commonDialogOnOK() isn't set. I fixed this by a cut-and-paste from another area of the commonDialog.js file; will attach fix.
Re-assining component to XP Apps; hope that's where this goes.
Component: Browser-General → XP Apps
really reassigning it
Assignee: asa → don
QA Contact: doronr → sairuh
Component: XP Apps → XP Apps: GUI Features
QA Contact: sairuh → jrgm
If a var is not scoped locally in JS, then it has global scope. So doing the QI a second time is redundant, no? It is of course better practice to declare your globals as such (add 'var param;' at the top of commonDialog.js) and that would suppress any warnings if running with the JS strict option.
Since Don has left, Vishy is taking his bugs in bulk, pending reassignment. thanks, Vishy
Assignee: don → vishy
get patch reviewed etc and checked in if correct.
Assignee: vishy → ben
Hello Matt, you still there? is this bug still relevant?
alecf in rev 1.29 of commonDialog.js (bug 58931) made 'param' clearer by changing it to gCommonDialogParam, to make it clear it was global in scope (and cleaned up a bunch of other warnings). This patch is now redundant. Marking WONTFIX (nothing left to fix).
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → WONTFIX
This much I know :-]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.