Closed
Bug 53697
Opened 24 years ago
Closed 24 years ago
xp filepicker not opening because content/global/filepicker.css not in jar.mn
Categories
(Core :: XUL, defect, P2)
Tracking
()
VERIFIED
FIXED
People
(Reporter: jag+mozbugs, Assigned: bryner)
Details
(Keywords: regression, Whiteboard: [rtm++] checked in on trunk)
Attachments
(1 file)
615 bytes,
patch
|
Details | Diff | Splinter Review |
This entry seems to be missing from xpfe/components/jar.mn, and prevents the xp filepicker from displaying on jar builds.
Reporter | ||
Comment 1•24 years ago
|
||
Tweaking summary, keyword magic, accepting bug, simple fix, needed for nsbeta3, will block Browser QA test B3, attaching patch.
Reporter | ||
Comment 2•24 years ago
|
||
Comment 3•24 years ago
|
||
r=axel@pike.org The ">" icons are really misleading, though the missing css doesn't keep the filepicker from starting. It's just bad UI. Axel
Reporter | ||
Comment 4•24 years ago
|
||
Hmmm, this is nice... When using jar files, missing css files fail silently, the filepicker loads, but with triangles instead of folder icons. When not using jar files, it doesn't load. I'll see if there's a bug on that. Anyway, now I just need a= :-)
Reporter | ||
Comment 5•24 years ago
|
||
r=/a=ben, and checked in, marking fixed
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•24 years ago
|
||
Reopening so we can try to land this on the branch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Updated•24 years ago
|
Assignee: disttsc → bryner
Status: REOPENED → NEW
Whiteboard: checked in on trunk
Reporter | ||
Comment 7•24 years ago
|
||
Assigning to bryner, who's volunteered lobbying to get this checked in on the branch.
Assignee | ||
Comment 8•24 years ago
|
||
Addding regression kw. This worked up until the landing of JAR files, when someone apparently forgot to add filepicker.css to the jar.mn. Right now, since we fail to load that file, directories get the regular tree twisty icon instead of the folder icon. This would be confusing for the user because these "twisties" CAN NOT be expanded as the icon would suggest. This is an extremely low-risk, trivial fix and I think we should get it in for RTM.
Status: NEW → ASSIGNED
Keywords: regression
Comment 9•24 years ago
|
||
rtm+ need info. Ben needs to indicate his a= approval in this bug report before we can change to rtm+
Priority: P3 → P2
Whiteboard: checked in on trunk → [rtm+ need info] checked in on trunk
Target Milestone: --- → M19
Comment 10•24 years ago
|
||
r=ben. waterson said he'd provide a= pending this review.
Assignee | ||
Comment 11•24 years ago
|
||
changing to rtm+ per ben's a=.
Whiteboard: [rtm+ need info] checked in on trunk → [rtm+] checked in on trunk
Comment 12•24 years ago
|
||
PDT marking [rtm++]
Whiteboard: [rtm+] checked in on trunk → [rtm++] checked in on trunk
Assignee | ||
Comment 13•24 years ago
|
||
checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•