615 bytes, patch
|Details | Diff | Splinter Review|
This entry seems to be missing from xpfe/components/jar.mn, and prevents the xp filepicker from displaying on jar builds.
Tweaking summary, keyword magic, accepting bug, simple fix, needed for nsbeta3, will block Browser QA test B3, attaching patch.
Created attachment 15304 [details] [diff] [review] [patch] add content/global/filepicker.css to jar.mn
email@example.com The ">" icons are really misleading, though the missing css doesn't keep the filepicker from starting. It's just bad UI. Axel
Hmmm, this is nice... When using jar files, missing css files fail silently, the filepicker loads, but with triangles instead of folder icons. When not using jar files, it doesn't load. I'll see if there's a bug on that. Anyway, now I just need a= :-)
r=/a=ben, and checked in, marking fixed
Reopening so we can try to land this on the branch
Assigning to bryner, who's volunteered lobbying to get this checked in on the branch.
Addding regression kw. This worked up until the landing of JAR files, when someone apparently forgot to add filepicker.css to the jar.mn. Right now, since we fail to load that file, directories get the regular tree twisty icon instead of the folder icon. This would be confusing for the user because these "twisties" CAN NOT be expanded as the icon would suggest. This is an extremely low-risk, trivial fix and I think we should get it in for RTM.
rtm+ need info. Ben needs to indicate his a= approval in this bug report before we can change to rtm+
r=ben. waterson said he'd provide a= pending this review.
changing to rtm+ per ben's a=.
PDT marking [rtm++]
verified fixed, trunk and branch.