537032 - [OS X 64-bit] css gradients are not painted

Status: VERIFIED FIXED

(Core :: Web Painting, defect)

Description

[philippe (part-time)]

Attachment: screenshot add-on manager

When Minefield is build in 64-bit mode, CSS gradients are not painted. The background is transparent instead.

This is also visible in chrome (e.g. the buttons at the top of the add-ons window)

Comment 1

[philippe (part-time)]

Attachment: html test case

There should be a yellow-to-blue diagonal gradient in the box.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Jeff, can you take this?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Yes

Comment 4

[Jeff Muizelaar [:jrmuizel]]

This is caused by using floats instead of CGFloats. CGFloat is double on 64bit. Ben is going to come up with a patch.

Comment 5

[Benoit Girard (:BenWa)]

Attachment: Replace float pointer types with CGFloat. CoreGraphics uses CGFloat which are float for 32-bits and double for 64-bits.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 421650 [details] [diff] [review]
Replace float pointer types with CGFloat. CoreGraphics uses CGFloat which are float for 32-bits and double for 64-bits.

Looks good.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

http://hg.mozilla.org/mozilla-central/rev/f85c8c1c111e

Comment 8

[philippe (part-time)]

Works fine with a build @ http://hg.mozilla.org/mozilla-central/rev/32b8675c4a23.

Thanks