537171 - defaulting navigation toolbar results in strange back/forward button types

Status: RESOLVED FIXED

(Toolkit :: Toolbars and Toolbar Customization, defect)

Description

[(mostly gone) XtC4UaLL [:xtc4uall]]

Attachment: screenshot showing bug

STR:
* new profile
* view/toolbars/customize
* hit "Restore Default Set"

result: the button type/size of the back/forward buttons is set to a "strange one" what differs from the normal big-size/small-size ones. also see attached screenshot showing the buggy state, big size and small size.

this regressed within http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=38754465ffde&tochange=3079370d6597

=> likely by Bug 500665 (thus trunk only)

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

one possible workaround to recieve the normal buttons would be ticking + unticking the "Use Small Icons" checkbox.

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

This makes the size default to "large" if not specified otherwise, as before bug 500665. We need to do the same for the mode, I think, although this was broken before bug 500665...

Comment 3

[[e-mail]]

Comment on attachment 419601 [details] [diff] [review]
patch

Ah, so this is only noticeable because winstripe's browser.css happens to rely on iconsize="large".

Comment 4

[Dão Gottwald [:dao]]

Yeah. Winstrpipe could be changed, but considering other applications and third-party themes, restoring the old behavior seems preferable.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/392f9ce6a71d