537216 - Unicode URLs are escaped in print titles

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Parag Nemade]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.6) Gecko/20091216 Fedora/3.5.6-1.fc12 Firefox/3.5.6
Build Identifier: 

On Fedora 12 system where I have
cairo-1.8.8-3.fc12.x86_64
firefox-3.5.6-1.fc12.x86_64


Reproducible: Always

Steps to Reproduce:
1) start firefox and enter URL http://mr.wikipedia.org
2) print this page as pdf


Actual Results:  
Unable to see Unicode string मुखपृष्ठ printed as URL address in pdf



Expected Results:  
It should display Unicode string and not its hex representation.

Comment 1

[Parag Nemade]

Attachment: print as pdf of http://mr.wikipedia.org

Comment 2

[Andrew Robbins]

This should probably be fixed in nsPrintEngine::GetDisplayTitleAndURL(). 

This function ultimately calls nsIPrintSettings::GetDocURL(), which seems to be implemented by both nsIPrintProgressParams and nsPrintSettings. Both of these return the docURI via ToNewUnicode(), which does nothing but copy the buffer. I believe what is needed to fix this is to call nsTextToSubURI::convertURItoUnicode() which actually decodes a URI to an IRI so that it may be displayed in the print settings properly.

Comment 3

[Simon Montagu :smontagu]

This happens with all printing, not just pdf

Comment 4

[Simon Montagu :smontagu]

Attachment: Patch

I'm not sure if the assumption that the URL is in UTF-8 is safe (though the existing code seems to make the same assumption).

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 419872 [details] [diff] [review]
Patch

+    textToSubURI->UnEscapeURIForUI(nsDependentCString("UTF-8"),
+                                   urlCStr, unescapedURI);

NS_LITERAL_CSTRING. And check for failure here?

+  } else {
+    *aURLStr = UTF8ToNewUnicode(urlCStr);
+  }

Don't bother. Just return an empty string.

Comment 6

[Simon Montagu :smontagu]

Pushed with those changes: http://hg.mozilla.org/mozilla-central/rev/5562675eab26

Comment 7

[Parag Nemade]

can this fix be backported on 1.9.2?

Comment 8

[Simon Montagu :smontagu]

Comment on attachment 419872 [details] [diff] [review]
Patch

Requesting approval1.9.2.1 after trunk baking. This is a big win for UE and usability when printing URLs with non-Latin titles, and the risk is minimal because we're only modifying one string, which is only used within the printing UI.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 419872 [details] [diff] [review]
Patch

We'll take this in 1.9.2.3 when the tree is open for that build; pretty simple patch, nice thing to do for non-Latin alphabeteers.

Comment 10

[LegNeato]

Comment on attachment 419872 [details] [diff] [review]
Patch

a=LegNeato for 1.9.2.5. Please ONLY land this on mozilla-1.9.2 default, as we
are still working on 1.9.2.4 on the relbranch

Comment 11

[Simon Montagu :smontagu]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/322dbb0c580a