537302 - jstest shell harness: allow running from other directories

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Mandelin [:dmandelin]]

Attachment: Patch

Currently, the jstest shell harness only works correctly if run from its directory (js/src/tests). This patch allows it to be run from other directories.

Comment 1

[Jeff Walden [:Waldo]]

Does this patch work with the current tests in ecma_5/Object?  I added some shell-only tests that rely on the current working directory's identity (see the n-of-4 tests there), and at a very cursory glance here I'm not sure whether the cwd while the tests run is js/src/tests any longer or not.

Comment 2

[David Mandelin [:dmandelin]]

(In reply to comment #1)
> Does this patch work with the current tests in ecma_5/Object?  I added some
> shell-only tests that rely on the current working directory's identity (see the
> n-of-4 tests there), and at a very cursory glance here I'm not sure whether the
> cwd while the tests run is js/src/tests any longer or not.

Yes, it works with the new tests. I did it by having the test harness change its cwd just before running the tests. It first converts the path to the JS shell to absolute, so it's still OK to pass a relative path on the command line.

Comment 3

[David Mandelin [:dmandelin]]

http://hg.mozilla.org/tracemonkey/rev/b1d30a2e0e50

Comment 4

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/b1d30a2e0e50