Closed
Bug 537304
Opened 15 years ago
Closed 15 years ago
jstest shell harness: spurious PASS output
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: dmandelin, Assigned: dmandelin)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
837 bytes,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
As part of another change, I forgot to update the logic that detects test failures for the PASS message, so it prints PASS even if there are failures.
Attachment #419604 -
Flags: review?(jorendorff)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 419604 [details] [diff] [review] Patch r=me. Note that you can omit `.keys()` there.
Attachment #419604 -
Flags: review?(jorendorff) → review+
|
Assignee | |
Comment 2•15 years ago
|
||
(In reply to comment #1) > (From update of attachment 419604 [details] [diff] [review]) > r=me. Note that you can omit `.keys()` there. Good point. Thanks. http://hg.mozilla.org/tracemonkey/rev/aeb1809789d9
Whiteboard: fixed-in-tracemonkey
|
||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/aeb1809789d9
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•