using 9/22 build of netscape 1) launch netscape 2) launch composer 3) insert default table 4) click inside the first cell 5) Insert | Table notice the cell changes color to red.. all platforms.
same problem if you click on the table icon on the toolbar... you can nest tables if you click pulldown Table | Insert | Table and click OK in the dialog.
actually its not changing the cell color to red, its just selecting it in the red color...
changing summary of bug report. you can only nest tables by going into Table | Insert | Table. but it doesn't work if you do it these ways: 1) Insert | Table 2) clicking on the Table button on the toolbar and then clicking OK in that dialog
I agree that using the "Table" item from the "Insert" menu should insert a nested table. That would be trivial to change. Using the toolbar button is "dual function" (true for all "object" buttons except for H.Line): they bring up properties if object is selected, in in this case, you're inside a table.
The fix for this is as trivial as it gets: - <menuitem accesskey="&inserttable.accesskey;" observes="cmd_table" value="&insertTableCmd.label;"/> + <menuitem accesskey="&inserttable.accesskey;" observes="cmd_InsertTable" value="&insertTableCmd.label;"/> The "cmd_InsertTable" is already being used in the Table | Insert | Table menuitem. Rick: Since you expressed concern about being able to insert nested tables, would you approve this change?
nested tables are an absolute must have, setting to p1
PDT: If risk is low, as Charlie says, then we'll take this as P1. But not a PR3 stop ship.
We need to do of the following: 1) fix the nested table bug, or 2) disable the UI for the feature.
First - I don't see the "nested table bug" that Rickg refers to. Please supply more info about that problem -- probably best to file a separate bug about that. But if that is not a problem or is easily fixable, I'd say the risk is as low as I could possibly imagine! Just execute a different, already existing command.
The testcase is easdy to reproduce. In mail create a table by using the Format/Table/Insert/Table... menu. Then select an empty cell. Now use the Insert/Table... menu option to enter a nested table. Nothing happens.
I'll bet that what rick is getting on the nested table is the table properties dialog and not the insert dialog -- I just tried his steps and that is what i get. Rick, is the title of the dialog on the Insert|Table say 'Table Properties'
I agree with Beppe, that the basic problem is that "Insert | Table" (that's the top level "Insert" menu) doesn't insert a table, but brings up the property dialog if you are already inside the table. As stated above, changeing that command fixes most of the UI confusion. In my current build, 'Insert | Table' *always* inserts a new table (after showing the small dialog). Please pay attention to what dialog comes up. But Rick has also revealed a different problem: After the first table, he is *selecting* a cell before inserting the nested table. You don't have to do that ( you can just put caret in a cell), but if you do, we mangle the table: we end up with 3 tables with the newest one in the middle (original table is split into 2 others.) So that needs to be addressed and I am working on a very easy fix for that.
marking nsbeta3- as this is already RTM++ and not necessary for PR3 per clayton.
This has been fixed in the tip tree
Reassigning to kin to checkin on the branch next week since I'm starting my sabatical
This can go in the branch now, right? No rush, just trying to get the branch vs. trunk diffs I'm reviewing under control. /be
sr=sfraser for the branch checkin.
Checked fix into Netscape_20000922_BRANCH for firstname.lastname@example.org: mozilla/editor/ui/composer/content/editorOverlay.xul revision 18.104.22.168 mozilla/editor/ui/dialogs/content/EdInsertTable.js revision 22.214.171.124 email@example.com sr,firstname.lastname@example.org
Beautiful. verified in 10/4 build.