537377 - Port several bugfixes from toolkit viewSource.js

Status: RESOLVED FIXED

(Core Graveyard :: View Source, defect)

Description

[Philip Chee]

Picking some 1.9.2 safe patches from:
http://hg.mozilla.org/releases/mozilla-1.9.2/log/7f85397aa446/toolkit/components/viewsource/content/viewSource.js

> Bug 469302 -  Page source code after form submit shows initial form page instead of new page
>   Bug 470357 -  view source window no longer reads from cache (does loads twice, broken for POST)

We don't have this bug but I think we should fix bz's nit in Bug 470357.

> Bug 480080 -  updateStatusBar not defined in gSelectionListener() in viewSource.js

This has been annoying me for ages since I use the Error Console + View Source frequently.

> Bug 425588 -  "Go to line" should always parse line number as decimal

This looks like a one line nobrainer.

Comment 1

[Philip Chee]

Attachment: Patch v1.0

> -    .interlinePosition = true;	
> +    .interlinePosition = true;

I'm sorry but I just had to remove the trailing tab. It was driving me crazy.

No UI is touched so presumably sr isn't needed.

Comment 2

[[e-mail]]

Comment on attachment 419676 [details] [diff] [review]
Patch v1.0

Except for bz's nit, since I'm not convinced that I want things to be in an inconsistent state if things go wrong halfway through.

Comment 3

[Philip Chee]

Attachment: Patch v1.1 (bz unnitted) r=neil [Checkin: See comment 4]

> Except for bz's nit, since I'm not convinced that I want things to be in an
> inconsistent state if things go wrong halfway through.
OK. Removed the nit.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 419737 [details] [diff] [review]
Patch v1.1 (bz unnitted) r=neil
[Checkin: See comment 4]


http://hg.mozilla.org/comm-central/rev/fc273a034e2f
with fixed |.interlinePosition = true;| indentation.