The default bug view has changed. See this FAQ.

Port several bugfixes from toolkit viewSource.js

RESOLVED FIXED

Status

Core Graveyard
View Source
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: compat-fx)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Picking some 1.9.2 safe patches from:
http://hg.mozilla.org/releases/mozilla-1.9.2/log/7f85397aa446/toolkit/components/viewsource/content/viewSource.js

> Bug 469302 -  Page source code after form submit shows initial form page instead of new page
>   Bug 470357 -  view source window no longer reads from cache (does loads twice, broken for POST)

We don't have this bug but I think we should fix bz's nit in Bug 470357.

> Bug 480080 -  updateStatusBar not defined in gSelectionListener() in viewSource.js

This has been annoying me for ages since I use the Error Console + View Source frequently.

> Bug 425588 -  "Go to line" should always parse line number as decimal

This looks like a one line nobrainer.
(Assignee)

Comment 1

7 years ago
Created attachment 419676 [details] [diff] [review]
Patch v1.0

> -    .interlinePosition = true;	
> +    .interlinePosition = true;

I'm sorry but I just had to remove the trailing tab. It was driving me crazy.

No UI is touched so presumably sr isn't needed.
Attachment #419676 - Flags: review?(neil)

Comment 2

7 years ago
Comment on attachment 419676 [details] [diff] [review]
Patch v1.0

Except for bz's nit, since I'm not convinced that I want things to be in an inconsistent state if things go wrong halfway through.
Attachment #419676 - Flags: review?(neil) → review+
(Assignee)

Comment 3

7 years ago
Created attachment 419737 [details] [diff] [review]
Patch v1.1 (bz unnitted) r=neil
[Checkin: See comment 4]

> Except for bz's nit, since I'm not convinced that I want things to be in an
> inconsistent state if things go wrong halfway through.
OK. Removed the nit.
Attachment #419676 - Attachment is obsolete: true
Attachment #419737 - Flags: review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
(Assignee)

Updated

7 years ago
Attachment #419737 - Attachment description: Patch v1.1 (bz unnitted) r=neil → [c-c checkin-needed] Patch v1.1 (bz unnitted) r=neil
Comment on attachment 419737 [details] [diff] [review]
Patch v1.1 (bz unnitted) r=neil
[Checkin: See comment 4]


http://hg.mozilla.org/comm-central/rev/fc273a034e2f
with fixed |.interlinePosition = true;| indentation.
Attachment #419737 - Attachment description: [c-c checkin-needed] Patch v1.1 (bz unnitted) r=neil → Patch v1.1 (bz unnitted) [Checkin: See comment 4]
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
(Assignee)

Updated

7 years ago
Attachment #419737 - Attachment description: Patch v1.1 (bz unnitted) [Checkin: See comment 4] → Patch v1.1 (bz unnitted) r=neil [Checkin: See comment 4]

Updated

7 years ago
Component: View Source → View Source
Product: SeaMonkey → Core Graveyard
Target Milestone: seamonkey2.1a1 → ---
You need to log in before you can comment on or make changes to this bug.