Closed
Bug 537419
Opened 15 years ago
Closed 15 years ago
crash [@ nsINode::GetCurrentDoc() ] from GetPrimaryFrameFor(null) in nsAutoScrollTimer::Notify
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: bzbarsky)
References
Details
(Keywords: crash, topcrash)
Crash Data
Attachments
(1 file)
|
752 bytes,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
http://crash-stats.mozilla.com/report/list?range_value=2&range_unit=weeks&signature=nsINode%3A%3AGetCurrentDoc%28%29&version=Firefox%3A3.7a1pre is another set of null-dereference topcrashes that started in December 25 builds, presumably a regression from bug 500882. At a quick glance it looks like this code: http://hg.mozilla.org/mozilla-central/annotate/127bc6ade9eb/layout/generic/nsSelection.cpp#l470 has to deal with mContent being null.
|
Assignee | |
Comment 1•15 years ago
|
||
Hrm. I'd audited this, but I guess nsIPresShell::GetCapturingContent can return null in Start(). Will add a null-check, though maybe it makes more sense to not start the timer at all in that case...
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•15 years ago
|
||
Attachment #419715 -
Flags: review?(dbaron)
|
Reporter | |
Comment 3•15 years ago
|
||
Comment on attachment 419715 [details] [diff] [review] Fix r=dbaron
Attachment #419715 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/cb5a303025fe
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Crash Signature: [@ nsINode::GetCurrentDoc() ]
You need to log in
before you can comment on or make changes to this bug.
Description
•