537456 - It is not possible to copy/paste Tasks from the Task View or Today Pane

Status: RESOLVED FIXED

(Calendar :: Tasks, defect)

Description

[pavel.zahradnik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; cs; rv:1.9.1.6) Gecko/20091201 Firefox/3.5.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; cs; rv:1.9.1.5) Gecko/20091204 Lightning/1.0b1 Thunderbird/3.0

It is not possible to copy/paste Tasks while this is possible to do with Events.

Reproducible: Always

Comment 1

[Lance Haverkamp]

Thanks for posting this.  Confirmed issue.  You can't even paste into the "click here to add a new task" box, you have to manually type.

Thanks,
Lance

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b3pre Thunderbird/3.1.15

Comment 2

[Lance Haverkamp]

Platform does include Linux (and probably all platforms).  Would someone with sufficient authority please update platform, thanks!

Lance

Comment 3

[Decathlon]

(In reply to Lance Haverkamp from comment #1)
> You can't even paste into the
> "click here to add a new task" box, you have to manually type.
> 
On Win7 I can't reproduce. I can paste with Ctrl+v keys or with context menu item in the two input box "Click here to add a new task" located in task view and today-pane's task section.
Moreover, I can do the same (keys and context menu) with task boxes in every view.

Thuderbird 8, Lightning 1.0

Comment 4

[Matthew Mecca [:mmecca]]

Cut and Copy don't work on the selected tasks in the task trees, and the task tree is missing the Cut/Copy/Paste commands.

Comment 5

[Lance Haverkamp]

This is behaving strangely...The other day I couldn't paste into that box, now I can.  I'll have to keep an eye on this. 

Using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b3pre Thunderbird/3.1.15

(current for my distro & version of Mint Linix)

Comment 6

[Matthew Mecca [:mmecca]]

Attachment: [checked-in]Fix v1

Adds cut/copy/paste to task trees

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 582627 [details] [diff] [review]
[checked-in]Fix v1

Review of attachment 582627 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp

::: calendar/base/content/calendar-task-tree.js
@@ +126,5 @@
>          document.getElementById("calendar_new_todo_todaypane_command").setAttribute("disabled", "true");
>      }
>  
> +    // make sure the paste menu item is enabled
> +    if (calendarController2.isCommandEnabled("cmd_paste")) {

So the paste command should always be enabled? Even if there are no items to paste? Maybe you can make this dependent on if there is something in the clipboard.

Comment 8

[Matthew Mecca [:mmecca]]

(In reply to Philipp Kewisch [:Fallen] from comment #7)

> So the paste command should always be enabled? Even if there are no items to
> paste? Maybe you can make this dependent on if there is something in the
> clipboard.

I think this should be done in the controller - I'll file a follow-up bug.

Comment 9

[Matthew Mecca [:mmecca]]

Pushed to comm-central - http://hg.mozilla.org/comm-central/rev/76e1d919b991

Comment 10

[Matthew Mecca [:mmecca]]

(In reply to Matthew Mecca [:mmecca] from comment #8)

> I think this should be done in the controller - I'll file a follow-up bug.

I take that back, the controller already does this properly, it's the task tree that always enables the paste command if a task is selected when the context menu is opened.

Comment 11

[Matthew Mecca [:mmecca]]

Attachment: Paste Fix

Disable paste command on task context menu if clipboard empty.

Comment 12

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 584670 [details] [diff] [review]
Paste Fix

You could also use:

setElementValue("cmd_paste", calendarController2.isCommandEnabled("cmd_paste") && "true", "disabled");

Or you could instead try:

goUpdateCommand("cmd_paste");

Comment 13

[Matthew Mecca [:mmecca]]

(In reply to Philipp Kewisch [:Fallen] from comment #12)

> Or you could instead try:
> 
> goUpdateCommand("cmd_paste");

That works.

Comment 14

[Matthew Mecca [:mmecca]]

Attachment: Paste Fix v2

Comment 15

[Matthew Mecca [:mmecca]]

Comment on attachment 585101 [details] [diff] [review]
Paste Fix v2

Pushed to comm-central - http://hg.mozilla.org/comm-central/rev/8e26b6757c39

Comment 16

[Matthew Mecca [:mmecca]]

Comment on attachment 585101 [details] [diff] [review]
Paste Fix v2

Wanted for comm-aurora? Fix v1 is there.

Comment 17

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

sure, go ahead!

Comment 18

[Matthew Mecca [:mmecca]]

Pushed to comm-aurora - http://hg.mozilla.org/releases/comm-aurora/rev/589748a1858b