Closed
Bug 537489
Opened 14 years ago
Closed 14 years ago
nsSigHandler.cpp should use _M_IX86 instead of _M_IA32
Categories
(Toolkit Graveyard :: Build Config, defect)
Tracking
(status1.9.2 final-fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
status1.9.2 | --- | final-fixed |
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
1.41 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
On exception handler of Windows, source code uses _M_IA32 macro. What is _M_IA32? Microsoft compiler defines _M_IX86 as x86, not _M_IA32. So these codes isn't compiled. (Because, although there is typo of X87SW (on code, it is X86SW!!!), build is successful.). We should use valid compiler macro for MSVC.
Assignee | ||
Comment 1•14 years ago
|
||
Assignee: nobody → m_kato
Assignee | ||
Updated•14 years ago
|
Attachment #419772 -
Flags: review?(benjamin)
Updated•14 years ago
|
Attachment #419772 -
Flags: review?(benjamin) → review+
Updated•14 years ago
|
Flags: blocking1.9.2+
Comment 2•14 years ago
|
||
This highlights that we have poor test coverage for the underlying problem. We should take another stab and making an automated test for this, maybe by building a broken plugin? Thanks for the report + patch.
Comment 3•14 years ago
|
||
We can certainly provide a method on the testplugin which does things to the FPU!
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/8c77f0e9037d going to push to 1.9.2 as soon as it clears m-c.
Updated•5 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•