Closed Bug 537489 Opened 14 years ago Closed 14 years ago

nsSigHandler.cpp should use _M_IX86 instead of _M_IA32

Categories

(Toolkit Graveyard :: Build Config, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

(status1.9.2 final-fixed)

RESOLVED FIXED
Tracking Status
status1.9.2 --- final-fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

On exception handler of Windows, source code uses _M_IA32 macro.  What is _M_IA32?  Microsoft compiler defines _M_IX86 as x86, not _M_IA32.  So these codes isn't compiled.  (Because, although there is typo of X87SW (on code, it is X86SW!!!), build is successful.).

We should use valid compiler macro for MSVC.
Attached patch patch v1Splinter Review
Assignee: nobody → m_kato
Attachment #419772 - Flags: review?(benjamin)
Attachment #419772 - Flags: review?(benjamin) → review+
Flags: blocking1.9.2+
This highlights that we have poor test coverage for the underlying problem. We should take another stab and making an automated test for this, maybe by building a broken plugin? Thanks for the report + patch.
We can certainly provide a method on the testplugin which does things to the FPU!
http://hg.mozilla.org/mozilla-central/rev/8c77f0e9037d
going to push to 1.9.2 as soon as it clears m-c.
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/f9be17b3df55
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Blocks: 533035
Flags: in-testsuite?
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: