clearer talos message for non-zero browser return code error

RESOLVED FIXED

Status

Release Engineering
General
P3
normal
RESOLVED FIXED
8 years ago
4 years ago

People

(Reporter: dbaron, Assigned: alice)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
I thought crashes during talos runs showed minidumps in the log.  However, this Windows log is reported as a crash, but has no minidump:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1262432274.1262432944.2166.gz
WINNT 6.0 mozilla-central talos svg on 2010/01/02 03:37:54  
FAIL: Busted: tsvg_opacity
FAIL: browser crash (code 1)

There have also been some Mac talos runs shown as "terminated", but I'm not sure if those are crashes or something else weird.
(Assignee)

Comment 1

8 years ago
This indicates that the browser closed with a return value other than 0, which talos considers to be a failure.  In this case the value was 1, which is all the information that talos has to go on.
(Assignee)

Comment 2

8 years ago
This is the expected behavior on return codes from the browser other than 0.

Closing.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → INVALID
(Assignee)

Comment 3

8 years ago
Should fix the talos message so that this is less confusing.
Assignee: nobody → anodelman
Status: RESOLVED → REOPENED
Priority: -- → P3
Resolution: INVALID → ---
Summary: crashes in talos not showing minidumps? → clearer talos message for non-zero browser return code error
(Assignee)

Comment 4

8 years ago
Created attachment 421155 [details] [diff] [review]
[checked in]clearer message for non-zero return code from browser
Attachment #421155 - Flags: review?(catlee)

Updated

8 years ago
Attachment #421155 - Flags: review?(catlee) → review+
(Assignee)

Updated

8 years ago
Blocks: 539135
(Assignee)

Comment 5

8 years ago
Comment on attachment 421155 [details] [diff] [review]
[checked in]clearer message for non-zero return code from browser

/cvsroot/mozilla/testing/performance/talos/bcontroller.py,v  <--  bcontroller.py
new revision: 1.10; previous revision: 1.9
done
Attachment #421155 - Attachment description: clearer message for non-zero return code from browser → [checked in]clearer message for non-zero return code from browser
Attachment #421155 - Flags: checked-in+
(Assignee)

Updated

8 years ago
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.