537615 - impossible to position cursor in text field

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

If there is text in a text box with focus and you click some where in the middle of the text to reposition the cursor the text box will flash blue and then re-take focus with the cursor at the end of the text. The end result is its impossible to edit the text in a text box with out deleting everything after it.

I see this on the samsung Omnia II, but I suspect its platform independent.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

I see this on the n900 as well

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

yes, this is platform independent.

The patch prevent setting the element to be set as the current element of FormHelper if it is already.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 420227 [details] [diff] [review]
Patch

>diff -r 24fa03e7ddac chrome/content/browser.js

>         if (FormHelper.canShowUIFor(element)) {
>-          FormHelper.open(element);
>-          return;
>+          if (FormHelper.getCurrentElement() != element || gFocusManager.focusedElement != element) {
>+            FormHelper.open(element);

Could we move the currentElement check into FormHelper.open ? If aElement == currentElement just return

Maybe the gFocusManager.focusedElement check could go there too

Let me know what you think

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Makes sense.

We just need to return a boolean indicating if something has been done to know if we should prevent the default (mousedown/mouseup) action or not

Comment 5

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mobile-browser/rev/7084ff222475

Comment 6

[Aakash Desai [:aakashd]]

Is there a test site where this works?


I am still seeing the blue highlight whenever I tap on the editing text box even when its the current element (i.e. the cursor is blinking there).

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds (I'm not a fan of the blue highlighting everytime I click on it though):

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2b6pre) Gecko/20091228 Namoroka/3.6b6pre Fennec/1.0a4pre

and

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2pre) Gecko/20100111 Firefox/3.6pre Fennec/1.1a1pre